iframe-proxy

tronikos · 2026-10-16T01:12:06Z

Proposed change

Fix the SolarEdge module statistics sum resetting to 0 after the integration
has not updated for more than a week.

The module statistics are cumulative, so a newly fetched window must continue
from the last sum before that window. _async_get_last_sums looked for the
statistic one hour before the window and, if it was missing, fell back to the
absolute last statistic for the statistic ID.

That fallback is wrong when statistics already exist inside the window. After
the first update following a gap, the same window can be fetched again (for
example when the integration is reloaded the same day). The absolute last
statistic is then one written by the previous update inside the window, so the
fallback used 0.0 and the whole window was rewritten starting from zero,
producing a large negative jump in the statistics graph.

The fix derives the sum before the window from the change of the first
statistic in the window. The recorder computes that change relative to the last
sum strictly before the window, so it is correct no matter how old the previous
statistics are, and it never resolves to a statistic written inside the window.
If the first statistic has no usable sum or change, it falls back to the last
statistic before the window, and then to 0. This also repairs windows already
corrupted by the bug on the next update.

The recorder query now returns the first statistic in the window instead of a
single row, so it fetches roughly the window's hourly rows per statistic ID
(about 168 rows per statistic per 12h refresh). This is deliberate: a bounded
query could miss the first row if it is not exactly at the window start and
fall back to a reset.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes SolarEdge module statistics: sum resets to 0 after a gap longer than one week #186653
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running: python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

The module statistics are cumulative, so a newly fetched window must continue from the last sum before that window. When the integration had not updated for more than a week, and the same window was fetched again before a statistic existed right before it, the fallback used the absolute last statistic. That statistic can be one written by an earlier update inside the window, which reset the sum to zero and created a large negative jump in the statistics graph. Derive the sum before the window from the change of the first statistic in the window instead. The recorder computes that change relative to the last sum strictly before the window, so it is correct no matter how old the previous statistics are, and never resolves to a statistic inside the window. Fall back to the last statistic before the window, and then to 0, when the first statistic has no usable sum or change.

home-assistant · 2026-10-16T01:12:18Z

Copilot

🟡 Changes recommended

A null leading statistic can still cause an existing cumulative baseline to reset to zero.

1 open finding

Preserve pre-window baseline when leading in-window sum is null · New

What changed in this PR

Fixes SolarEdge module statistics resetting after long gaps when the same data window is refreshed again, addressing #186653.

Changes:

Derives the cumulative baseline from recorded sum and change values.
Adds regression tests for repeated refreshes and newly added equipment.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

The baseline is derived from the change of the first statistic in the window. The recorder computes that change relative to the last sum before the window regardless of how many leading statistics have no sum, so scan for the first statistic that has both a sum and a change instead of only looking at the first one. Add a regression test with a statistic without a sum ahead of one with a sum.

Copilot

🔵 Needs a closer look

The fallback still loses a valid pre-window total when every in-window sum is null.

0 open findings

1 resolved since last review

Preserve pre-window baseline when leading in-window sum is null

🧠 Review effort: Balanced

…missing When every statistic in the window is missing a sum, the fallback returned the last statistic, which is inside the window and rejected as not before the window, so the baseline was lost. Fetch one more statistic than the number in the window and use the newest one before the window that has a sum. Add a regression test where no in-window statistic has a sum.

Copilot

🟢 Approval recommended

Recorder behavior supports the recovery logic, regression tests cover the key cases, and no blocking issues remain.

0 open findings

🧠 Review effort: Balanced

…2026.10.1 ➔ 2026.10.2) (#1247) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-operations/home-assistant](https://ghcr.io/home-operations/home-assistant) ([source](https://github.com/home-assistant/core)) | patch | `2026.10.1` → `2026.10.2` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-operations/home-assistant)</summary> ### [`v2026.10.2`](https://github.com/home-assistant/core/releases/tag/2026.10.2) [Compare Source](home-assistant/core@2026.10.1...2026.10.2) - Fix IndexError on out-of-range heater levels in Tesla Fleet ([@sebr] - [#178049]) ([tesla_fleet docs]) - Deduplicate sleepers within a single SleepIQ bed ([@derekcentrico] - [#181461]) ([sleepiq docs]) - Handle Enphase envoy Session is Closed in background tasks ([@catsmanac] - [#183172]) ([enphase_envoy docs]) - Treat MPD protocol errors as a connection failure ([@mattias-arrelid] - [#184481]) ([mpd docs]) - Bump py-opendisplay to 7.18.1 ([@g4bri3lDev] - [#184911]) ([opendisplay docs]) (dependency) - Bump aiotankerkoenig to 0.5.5 ([@mib1185] - [#185714]) ([tankerkoenig docs]) (dependency) - Tankerkoenig handle api errors config flow ([@mib1185] - [#185719]) ([tankerkoenig docs]) - Handle Gemini generation parameters and complete WAV TTS responses ([@oohhddaanngg] - [#185723]) ([google_generative_ai_conversation docs]) - Fix SmartTub error sensor reporting stale historical errors ([@mdz] - [#185726]) ([smarttub docs]) - Bump aiohttp to 3.14.5 ([@bdraco] - [#185746]) (dependency) - Mark Aquacell sensors unavailable when data is stale ([@alexborro] - [#185762]) ([aquacell docs]) - Bump aionanoleaf2 to 1.0.5 ([@feixm1] - [#185777]) ([nanoleaf docs]) (dependency) - Bump my-pv to 0.0.13 ([@rrooggiieerr] - [#185797]) ([my_pv docs]) (dependency) - Catch TimeoutError in the Nettigo Air Monitor integration ([@bieniu] - [#185812]) ([nam docs]) - Ignore devices without TR-064 support during FRITZ!Box Tools SSDP discovery ([@mib1185] - [#185816]) ([fritz docs]) - Bump arcam-fmj to 3.0.1 ([@elupus] - [#185887]) ([arcam_fmj docs]) (dependency) - Handle Alexa RequireRelink on cloud entity registry updates ([@balloob] - [#185894]) ([cloud docs]) - Redact schedule coordinates in Teslemetry and Tesla Fleet diagnostics ([@Bre77] - [#185905]) ([teslemetry docs]) ([tesla_fleet docs]) - Report a dedicated error when the Tedee bridge has no locks ([@zweckj] - [#185907]) ([tedee docs]) - Prevent WiiM browse failures from marking devices unavailable ([@Linkplay2020] - [#185926]) ([wiim docs]) - Fix group sensor crash when the group has no members ([@joostlek] - [#185931]) ([group docs]) - Do not cut off KNX SQLite telegram store initialization with a timeout ([@farmio] - [#185940]) ([knx docs]) - Bump nyt_games to 1.0.1 ([@joostlek] - [#185968]) ([nyt_games docs]) (dependency) - Gate Nanoleaf event listener on supports_events ([@loebi-ch] - [#185977]) ([nanoleaf docs]) - Fix MQTT device triggers and tags firing twice after reload ([@klejejs] - [#185998]) ([mqtt docs]) - Fix FRITZ!SmartHome SSDP host selection ([@mib1185] - [#186029]) ([fritzbox docs]) - switch Broadlink to broadlink-async (fixes [#184800](home-assistant/core#184800), replaces [#184806](home-assistant/core#184806)) ([@DAB-LABS] - [#186053]) ([broadlink docs]) - Fix weatherflow last_reset updating on every device report ([@jeeftor] - [#186141]) ([weatherflow docs]) - Bump weatherflow4py to 1.5.12 ([@jeeftor] - [#186142]) ([weatherflow_cloud docs]) (dependency) - Bump intellifire4py to 4.5.6 ([@jeeftor] - [#186143]) ([intellifire docs]) (dependency) - Fix scrape subentry reconfigure flow not finishing ([@joostlek] - [#186144]) ([scrape docs]) - pin pycares to 5.0.1 ([@aclerici38] - [#186164]) - Allow a list of states for state conditions with a duration ([@emontnemery] - [#186165]) - Bump airthings-ble to 1.3.1 ([@LaStrada] - [#186387]) ([airthings_ble docs]) (dependency) - Guard owner and existing credentials in auth provider create command ([@zweckj] - [#186398]) ([config docs]) - Fetch missing Renault vehicle details ([@epenet] - [#186402]) ([renault docs]) - Fix Discogs random record sensor when release has no format description ([@cerealkiller57540] - [#186405]) ([discogs docs]) - Fix permissions validation for ProxmoxVE ([@CoMPaTech] - [#186420]) ([proxmoxve docs]) - Hide MELCloud Home swing modes on units without vanes ([@erwindouna] - [#186468]) ([melcloud_home docs]) - Fix modbus reload without YAML config ([@joyjit] - [#186554]) ([modbus docs]) - Revoke refresh tokens when removing a user ([@frenck] - [#186558]) - Redact credentials and host in SFR Box diagnostics ([@epenet] - [#186668]) ([sfr_box docs]) - Fix SolarEdge module statistics sum resetting after a gap ([@tronikos] - [#186753]) ([solaredge docs]) - Bump deebot-client to 18.7.0 ([@edenhaus] - [#186779]) ([ecovacs docs]) (dependency) - Redact identifying data in NRGkick diagnostics ([@andijakl] - [#186781]) ([nrgkick docs]) - Persist Ecovacs account credentials to avoid device verification ([@erwindouna] - [#186796]) ([ecovacs docs]) - Update frontend to [`2026093`](https://github.com/home-assistant/core/commit/20260930).4 ([@bramkragten] - [#186813]) ([frontend docs]) (dependency) - Fix Fritz setup failing when UPnP info lacks NewEnable key ([@mib1185] - [#186896]) ([fritz docs]) - Bump aiomelcloudhome to 0.3.0 ([@erwindouna] - [#185769]) ([melcloud_home docs]) (dependency) - Pin pypasser below 1.0.0 ([@erwindouna] - [#186527]) [#178049]: home-assistant/core#178049 [#181461]: home-assistant/core#181461 [#183172]: home-assistant/core#183172 [#184481]: home-assistant/core#184481 [#184707]: home-assistant/core#184707 [#184911]: home-assistant/core#184911 [#185554]: home-assistant/core#185554 [#185714]: home-assistant/core#185714 [#185719]: home-assistant/core#185719 [#185723]: home-assistant/core#185723 [#185726]: home-assistant/core#185726 [#185746]: home-assistant/core#185746 [#185762]: home-assistant/core#185762 [#185769]: home-assistant/core#185769 [#185777]: home-assistant/core#185777 [#185797]: home-assistant/core#185797 [#185812]: home-assistant/core#185812 [#185816]: home-assistant/core#185816 [#185887]: home-assistant/core#185887 [#185894]: home-assistant/core#185894 [#185905]: home-assistant/core#185905 [#185907]: home-assistant/core#185907 [#185926]: home-assistant/core#185926 [#185931]: home-assistant/core#185931 [#185940]: home-assistant/core#185940 [#185968]: home-assistant/core#185968 [#185977]: home-assistant/core#185977 [#185998]: home-assistant/core#185998 [#186029]: home-assistant/core#186029 [#186053]: home-assistant/core#186053 [#186141]: home-assistant/core#186141 [#186142]: home-assistant/core#186142 [#186143]: home-assistant/core#186143 [#186144]: home-assistant/core#186144 [#186164]: home-assistant/core#186164 [#186165]: home-assistant/core#186165 [#186387]: home-assistant/core#186387 [#186398]: home-assistant/core#186398 [#186402]: home-assistant/core#186402 [#186405]: home-assistant/core#186405 [#186420]: home-assistant/core#186420 [#186468]: home-assistant/core#186468 [#186527]: home-assistant/core#186527 [#186554]: home-assistant/core#186554 [#186558]: home-assistant/core#186558 [#186668]: home-assistant/core#186668 [#186753]: home-assistant/core#186753 [#186779]: home-assistant/core#186779 [#186781]: home-assistant/core#186781 [#186796]: home-assistant/core#186796 [#186813]: home-assistant/core#186813 [#186896]: home-assistant/core#186896 [@Bre77]: https://github.com/Bre77 [@CoMPaTech]: https://github.com/CoMPaTech [@DAB-LABS]: https://github.com/DAB-LABS [@LaStrada]: https://github.com/LaStrada [@Linkplay2020]: https://github.com/Linkplay2020 [@aclerici38]: https://github.com/aclerici38 [@alexborro]: https://github.com/alexborro [@andijakl]: https://github.com/andijakl [@balloob]: https://github.com/balloob [@bdraco]: https://github.com/bdraco [@bieniu]: https://github.com/bieniu [@bramkragten]: https://github.com/bramkragten [@catsmanac]: https://github.com/catsmanac [@cerealkiller57540]: https://github.com/cerealkiller57540 [@derekcentrico]: https://github.com/derekcentrico [@edenhaus]: https://github.com/edenhaus [@elupus]: https://github.com/elupus [@emontnemery]: https://github.com/emontnemery [@epenet]: https://github.com/epenet [@erwindouna]: https://github.com/erwindouna [@farmio]: https://github.com/farmio [@feixm1]: https://github.com/feixm1 [@frenck]: https://github.com/frenck [@g4bri3lDev]: https://github.com/g4bri3lDev [@jeeftor]: https://github.com/jeeftor [@joostlek]: https://github.com/joostlek [@joyjit]: https://github.com/joyjit [@klejejs]: https://github.com/klejejs [@loebi-ch]: https://github.com/loebi-ch [@mattias-arrelid]: https://github.com/mattias-arrelid [@mdz]: https://github.com/mdz [@mib1185]: https://github.com/mib1185 [@oohhddaanngg]: https://github.com/oohhddaanngg [@rrooggiieerr]: https://github.com/rrooggiieerr [@sebr]: https://github.com/sebr [@tronikos]: https://github.com/tronikos [@zweckj]: https://github.com/zweckj [airthings_ble docs]: https://www.home-assistant.io/integrations/airthings_ble/ [aquacell docs]: https://www.home-assistant.io/integrations/aquacell/ [arcam_fmj docs]: https://www.home-assistant.io/integrations/arcam_fmj/ [broadlink docs]: https://www.home-assistant.io/integrations/broadlink/ [cloud docs]: https://www.home-assistant.io/integrations/cloud/ [config docs]: https://www.home-assistant.io/integrations/config/ [discogs docs]: https://www.home-assistant.io/integrations/discogs/ [ecovacs docs]: https://www.home-assistant.io/integrations/ecovacs/ [enphase_envoy docs]: https://www.home-assistant.io/integrations/enphase_envoy/ [fritz docs]: https://www.home-assistant.io/integrations/fritz/ [fritzbox docs]: https://www.home-assistant.io/integrations/fritzbox/ [frontend docs]: https://www.home-assistant.io/integrations/frontend/ [google_generative_ai_conversation docs]: https://www.home-assistant.io/integrations/google_generative_ai_conversation/ [group docs]: https://www.home-assistant.io/integrations/group/ [intellifire docs]: https://www.home-assistant.io/integrations/intellifire/ [knx docs]: https://www.home-assistant.io/integrations/knx/ [melcloud_home docs]: https://www.home-assistant.io/integrations/melcloud_home/ [modbus docs]: https://www.home-assistant.io/integrations/modbus/ [mpd docs]: https://www.home-assistant.io/integrations/mpd/ [mqtt docs]: https://www.home-assistant.io/integrations/mqtt/ [my_pv docs]: https://www.home-assistant.io/integrations/my_pv/ [nam docs]: https://www.home-assistant.io/integrations/nam/ [nanoleaf docs]: https://www.home-assistant.io/integrations/nanoleaf/ [nrgkick docs]: https://www.home-assistant.io/integrations/nrgkick/ [nyt_games docs]: https://www.home-assistant.io/integrations/nyt_games/ [opendisplay docs]: https://www.home-assistant.io/integrations/opendisplay/ [proxmoxve docs]: https://www.home-assistant.io/integrations/proxmoxve/ [renault docs]: https://www.home-assistant.io/integrations/renault/ [scrape docs]: https://www.home-assistant.io/integrations/scrape/ [sfr_box docs]: https://www.home-assistant.io/integrations/sfr_box/ [sleepiq docs]: https://www.home-assistant.io/integrations/sleepiq/ [smarttub docs]: https://www.home-assistant.io/integrations/smarttub/ [solaredge docs]: https://www.home-assistant.io/integrations/solaredge/ [tankerkoenig docs]: https://www.home-assistant.io/integrations/tankerkoenig/ [tedee docs]: https://www.home-assistant.io/integrations/tedee/ [tesla_fleet docs]: https://www.home-assistant.io/integrations/tesla_fleet/ [teslemetry docs]: https://www.home-assistant.io/integrations/teslemetry/ [weatherflow docs]: https://www.home-assistant.io/integrations/weatherflow/ [weatherflow_cloud docs]: https://www.home-assistant.io/integrations/weatherflow_cloud/ [wiim docs]: https://www.home-assistant.io/integrations/wiim/ </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Berlin) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.xcd.dev/gabrielcosi/home-ops/pulls/1247

Copilot AI balanced review requested due to automatic review settings October 16, 2026 01:12

tronikos requested a review from bdraco as a code owner October 16, 2026 01:12

home-assistant Bot added bugfix cla-signed has-tests integration: solaredge small-pr PRs with less than 30 lines. labels Oct 16, 2026

home-assistant Bot assigned bdraco Oct 16, 2026

home-assistant Bot added by-code-owner Quality Scale: No score labels Oct 16, 2026

Copilot started reviewing on behalf of tronikos October 16, 2026 01:12

View session

tronikos added this to the 2026.10.2 milestone Oct 16, 2026

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Comment thread homeassistant/components/solaredge/coordinator.py

Copilot AI balanced review requested due to automatic review settings October 16, 2026 01:40

Copilot started reviewing on behalf of tronikos October 16, 2026 01:40

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 16, 2026 01:55

Copilot started reviewing on behalf of tronikos October 16, 2026 01:55

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

balloob approved these changes Oct 16, 2026

View reviewed changes

balloob merged commit 6c81847 into home-assistant:dev Oct 16, 2026
36 checks passed

frenck added the cherry-picked label Oct 16, 2026

frenck pushed a commit that referenced this pull request Oct 16, 2026

Fix SolarEdge module statistics sum resetting after a gap (#186753)

6130fff

frenck mentioned this pull request Oct 16, 2026

2026.10.2 #186913

Merged

github-actions Bot locked and limited conversation to collaborators Oct 17, 2026

File	Description
tests/components/solaredge/test_coordinator.py	Tests repeated windows after gaps and new equipment.
homeassistant/components/solaredge/coordinator.py	Updates pre-window cumulative sum recovery.

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

Fix SolarEdge module statistics sum resetting after a gap - #186753

Fix SolarEdge module statistics sum resetting after a gap#186753
balloob merged 3 commits into
home-assistant:devfrom
tronikos:fix-solaredge-statistics-sum-reset

tronikos commented Oct 16, 2026 •

edited

Loading

Uh oh!

home-assistant Bot commented Oct 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

tronikos commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented Oct 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tronikos commented Oct 16, 2026 •

edited

Loading