Fix TOLO availability on failed updates by erwindouna · Pull Request #185505 · home-assistant/core · GitHub
Skip to content

Fix TOLO availability on failed updates - #185505

Merged
frenck merged 1 commit into
home-assistant:devfrom
erwindouna:coordinator-available-tolo
Oct 9, 2026
Merged

frenck merged 1 commit into
home-assistant:devfrom
erwindouna:coordinator-available-tolo

Conversation

@erwindouna

Copy link
Copy Markdown
Member

Breaking change

Proposed change

The available override only looked at the lamp state and mode, so the entities stayed available with stale data after a failed update. It now also checks super().available, which removes the W7449 suppression; a test covers unavailable and recovery.

Part of home-assistant/epics#141.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI balanced review requested due to automatic review settings October 9, 2026 15:03
@home-assistant home-assistant Bot added small-pr PRs with less than 30 lines. Quality Scale: No score labels Oct 9, 2026
@home-assistant

home-assistant Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused fix matches the coordinator contract and is adequately tested.

0 open findings

What changed in this PR

Fixes TOLO’s next-color button availability after coordinator update failures.

Changes:

  • Includes coordinator availability in the button’s availability check.
  • Adds fixtures and a test covering failure and recovery.
File Description
homeassistant/​components/​tolo/​button.py Gates button availability on coordinator health.
tests/​components/​tolo/​conftest.py Adds shared TOLO test fixtures.
tests/​components/​tolo/​test_button.py Tests unavailable and recovery states.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@frenck frenck added this to the 2026.10.1 milestone Oct 9, 2026
@frenck
frenck merged commit 9b7e189 into home-assistant:dev Oct 9, 2026
37 checks passed
@frenck frenck mentioned this pull request Oct 9, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants