Fix storing traces for automations without an ID by Kevin-Tamayose · Pull Request #185161 · home-assistant/core · GitHub
Skip to content

Fix storing traces for automations without an ID - #185161

Merged
frenck merged 1 commit into
home-assistant:devfrom
Kevin-Tamayose:fix/automation-traces-without-id
Oct 9, 2026
Merged

frenck merged 1 commit into
home-assistant:devfrom
Kevin-Tamayose:fix/automation-traces-without-id

Conversation

@Kevin-Tamayose

Copy link
Copy Markdown
Contributor

Automations without an ID were stored under automation.None and left in a running state. Do not store traces when no automation ID is available.

Proposed change

Automations without an ID were stored under automation.None and left in a
running state because their traces were stored but never finalized.

Do not store automation traces when no automation ID is available. Automations
without an ID remain valid and continue to execute normally.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Automations without an ID were stored under automation.None and left
in a running state. Do not store traces when no automation ID is
available.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@home-assistant

home-assistant Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@home-assistant

home-assistant Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (trace) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of trace can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign trace Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@Xyolyp

Xyolyp commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@frenck frenck added this to the 2026.10.1 milestone Oct 9, 2026

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @Kevin-Tamayose 👋

I turned my lights green for this one. Thanks!

By the way, congratulations on your first contribution to Home Assistant! Welcome aboard 🎉

../Frenck

                       

Blogging my personal ramblings at frenck.dev

Here is a dad joke for you:

Why did the fireman wear red, white, and blue suspenders? To hold his pants up.

@frenck
frenck merged commit 4bdd4d1 into home-assistant:dev Oct 9, 2026
55 checks passed
@frenck frenck mentioned this pull request Oct 9, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Traces of automations without an id are stored under "None" and never finish

4 participants