Bump pyicloud to 2.7.0 by FezVrasta · Pull Request #184728 · home-assistant/core · GitHub
Skip to content

Bump pyicloud to 2.7.0 - #184728

Merged
joostlek merged 1 commit into
home-assistant:devfrom
FezVrasta:bump-pyicloud-to-2.7.0
Oct 8, 2026
Merged

joostlek merged 1 commit into
home-assistant:devfrom
FezVrasta:bump-pyicloud-to-2.7.0

Conversation

@FezVrasta

@FezVrasta FezVrasta commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Proposed change

Bumps pyicloud from 2.6.5 to 2.7.0.

2.7.0 requests Protected Cloud Storage access before using the Reminders service (timlaing/pyicloud#317). Without it, accounts with Advanced Data Protection get every reminder back with an undecodable title, so the to-do lists added in 2026.10 come up empty and the log fills with TitleDocument decode failed lines.

I also updated the comments and the one-time warning in the reminders coordinator, which said Home Assistant can't read Reminders on ADP accounts yet. The skip for undecoded reminders stays as a safety net, since writing one back would overwrite its real title.

Release notes: https://github.com/timlaing/pyicloud/releases/tag/2.7.0
Diff: timlaing/pyicloud@2.6.5...2.7.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI balanced review requested due to automatic review settings October 7, 2026 16:42
@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: icloud small-pr PRs with less than 30 lines. labels Oct 7, 2026
@home-assistant

home-assistant Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency pins are consistent, and the related messaging accurately reflects the corrected upstream behavior.

0 open findings

What changed in this PR

Updates pyicloud to restore iCloud Reminders support for Advanced Data Protection accounts.

Changes:

  • Bumps pyicloud from 2.6.5 to 2.7.0.
  • Updates reminders fallback documentation and warning text.
File Description
requirements_all.txt Updates the generated dependency pin.
homeassistant/​components/​icloud/​manifest.json Updates the integration dependency.
homeassistant/​components/​icloud/​coordinator.py Reflects the new decryption behavior in comments and logging.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Check requirements

Checked at commit fd9a0c8.

All requirements checks passed. ✅

Package Old New No Advisories Not Yanked Repo Public CI Upload Release Pipeline Security PR Link Async Safe
pyicloud 2.6.5 2.7.0 ✅ ✅ ✅ ✅ ✅ ☑️ ✅ ✅
📦 pyicloud: 2.6.5 → 2.7.0
  • No Advisories: ✅ No active advisories reported by PyPI for version 2.7.0.
  • Not Yanked: ✅ Version 2.7.0 is a live (non-yanked) release.
  • Repo Public: ✅ https://github.com/timlaing/pyicloud is publicly accessible.
  • CI Upload: ✅ Trusted Publisher attestation found (GitHub).
  • Release Pipeline: ✅ OIDC via Trusted Publisher attestation (GitHub); automated CI upload verified by PyPI.
  • Security: ☑️ Baseline scan found nothing obvious in pyproject.toml, pyicloud/init.py, pyicloud/cmdline.py, requirements.txt. This is not a security review — only the cheap checks were run.
  • PR Link: ✅ PR description links to the compare URL timlaing/pyicloud@2.6.5...2.7.0, which mentions both 2.6.5 and 2.7.0.
  • Async Safe: ✅ Sync-only library (requests-based, no async def in the source tree, no asyncio/aiohttp/httpx/anyio dependency, no Framework :: AsyncIO classifier); Home Assistant integrations must wrap calls in an executor.

Generated by Check requirements (AW) · copilot · auto · 46.8 AIC · ⌖ 8.33 AIC · ⊞ 13.4K · ◷

@epenet epenet added this to the 2026.10.1 milestone Oct 7, 2026
@FezVrasta
FezVrasta marked this pull request as ready for review October 8, 2026 10:14
@FezVrasta
FezVrasta requested a review from Quentame as a code owner October 8, 2026 10:14
@joostlek
joostlek merged commit cc9dce2 into home-assistant:dev Oct 8, 2026
52 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: icloud Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADP-enabled accounts can’t decrypt reminder titles/content

6 participants