{{ message }}
Repository navigation
Add Hisense AC (0x138C/0x3601) to Matter dry and fan mode device lists - #184589
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted allowlist additions match the reported device capabilities and existing implementation pattern.
Review effort: Balanced
Findings: None
What changed in this PR
Adds Hisense AP1024TW1LA Matter support for dry and fan-only HVAC modes.
Changes:
- Adds vendor/product ID
0x138C/0x3601to both mode allowlists.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breaking change
Proposed change
The Matter specification has no feature flag for dry and fan only modes, so the Matter integration keeps lists of devices that support them. The Hisense AP1024TW1LA portable air conditioner (vendor
0x138C, product0x3601) wasn't in either list, so Home Assistant only offered off and cool, and refused to switch it to dry or fan only, while the device itself supports both.This adds the device to both lists, next to the Hisense product that was added in #167282.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: