Add Hisense AC (0x138C/0x3601) to Matter dry and fan mode device lists by frenck · Pull Request #184589 · home-assistant/core · GitHub
Skip to content

Add Hisense AC (0x138C/0x3601) to Matter dry and fan mode device lists - #184589

Merged
TheJulianJES merged 1 commit into
devfrom
frenck/fix-matter-hisense-modes
Oct 6, 2026
Merged

TheJulianJES merged 1 commit into
devfrom
frenck/fix-matter-hisense-modes

Conversation

@frenck

@frenck frenck commented Oct 6, 2026

Copy link
Copy Markdown
Member

Breaking change

Proposed change

The Matter specification has no feature flag for dry and fan only modes, so the Matter integration keeps lists of devices that support them. The Hisense AP1024TW1LA portable air conditioner (vendor 0x138C, product 0x3601) wasn't in either list, so Home Assistant only offered off and cool, and refused to switch it to dry or fan only, while the device itself supports both.

This adds the device to both lists, next to the Hisense product that was added in #167282.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@frenck
frenck requested a review from a team as a code owner October 6, 2026 23:33
Copilot AI balanced review requested due to automatic review settings October 6, 2026 23:33
@home-assistant home-assistant Bot added bugfix cla-signed integration: matter small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage Quality Scale: No score labels Oct 6, 2026
@home-assistant

home-assistant Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The targeted allowlist additions match the reported device capabilities and existing implementation pattern.

Review effort: Balanced
Findings: None

What changed in this PR

Adds Hisense AP1024TW1LA Matter support for dry and fan-only HVAC modes.

Changes:

  • Adds vendor/product ID 0x138C/0x3601 to both mode allowlists.
File Description
homeassistant/​components/​matter/​climate.py Enables dry and fan-only modes for the Hisense device.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@frenck frenck added this to the 2026.10.0 milestone Oct 6, 2026

@TheJulianJES TheJulianJES left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES
TheJulianJES merged commit 7150b5e into dev Oct 6, 2026
38 checks passed
@TheJulianJES
TheJulianJES deleted the frenck/fix-matter-hisense-modes branch October 6, 2026 23:42
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed integration: matter Quality Scale: No score small-pr PRs with less than 30 lines. Top 50 Integration is ranked within the top 50 by usage Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Matter: Hisense AC (0x138C / 0x3601) missing Dry and Fan-Only modes

3 participants