{{ message }}
Repository navigation
Consider next name part when unprefixing entity name - #184526
Merged
MindFreeze merged 2 commits intoOct 7, 2026
Merged
MindFreeze merged 2 commits into
MindFreeze merged 2 commits into
Conversation
home-assistant
Bot
added
bugfix
cla-signed
core
small-pr
1 of 12 tasks
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused logic correction is consistent with naming-chain semantics and is covered by the updated regression test.
Review effort: Balanced
Findings: None
What changed in this PR
Updates entity-name validation so device prefixes are considered only when the naming chain includes the device.
Changes:
- Respect
next_name_partwhen unprefixing entity names. - Test assigning an own area with a name matching the device.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…when-unprefixing-entity-name
MartinHjelmare
approved these changes
Oct 7, 2026
MindFreeze
deleted the
ap/h/entity_registry/consider-next-name-part-when-unprefixing-entity-name
branch
October 7, 2026 05:39
frenck
pushed a commit
that referenced
this pull request
Oct 7, 2026
Co-authored-by: Robert Resch <robert@resch.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Consider next name part when unprefixing entity name.
The device name prefix is stripped from a user-set entity name only when the device is a name part of the entity, i.e. when
next_name_partisdevice, matching the full name computation.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: