{{ message }}
Repository navigation
Don't remove the WLED stop listener twice on unload - #184412
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted lifecycle fix is correct and covered by a focused regression test.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents duplicate WLED stop-listener removal during config-entry unload.
Changes:
- Clears the unsubscribe callback after invocation.
- Adds regression coverage for unloading an active WebSocket listener.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
epenet
approved these changes
Oct 6, 2026
VladislavLevitskii
pushed a commit
to VladislavLevitskii/core
that referenced
this pull request
Oct 6, 2026
frenck
added a commit
that referenced
this pull request
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breaking change
Proposed change
Unloading a WLED entry with an open WebSocket removed the listener for Home Assistant stopping, and the WebSocket listener, ended by that same disconnect, removed it again. That logs "Unable to remove unknown job listener" with a traceback.
The unload now clears it after removing it, so whichever of the two comes second skips it.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: