{{ message }}
Repository navigation
Bump pywaze to 1.2.3 and close Waze clients on unload - #183923
Merged
Merged
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
home-assistant
Bot
added
bugfix
cla-needed
Hacktoberfest
integration: waze_travel_time
small-pr
Contributor
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Temporary clients used by services and config validation remain unclosed, and lifecycle cleanup lacks test coverage.
Review effort: Balanced
Findings: 1
What changed in this PR
Bumps pywaze to restore Waze routing after HTTP 403 responses and adds client cleanup during config-entry unload.
Changes:
- Updates pywaze from 1.2.1 to 1.2.3.
- Registers the config-entry client for cleanup on unload.
- Introduces curl-cffi fallback support through pywaze.
| File | Description |
|---|---|
requirements_all.txt |
Updates the generated pywaze requirement. |
homeassistant/components/waze_travel_time/manifest.json |
Updates the integration dependency. |
homeassistant/components/waze_travel_time/__init__.py |
Closes the entry client during unload. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eifinger
force-pushed
the
bump-pywaze-to-1.2.3
branch
from
October 1, 2026 16:44
b389814 to
0863ffb
Compare
Contributor
Check requirementsChecked at commit All requirements checks passed. ✅
📦 pywaze: 1.2.1 → 1.2.3
|
Contributor
Check requirementsChecked at commit All requirements checks passed. ✅
📦 pywaze: 1.2.1 → 1.2.3
|
eifinger
force-pushed
the
bump-pywaze-to-1.2.3
branch
from
October 1, 2026 17:00
0863ffb to
864ed9d
Compare
Contributor
Check requirementsChecked at commit All requirements checks passed. ✅ 📦 pywaze: 1.2.1 → 1.2.3
|
eifinger
marked this pull request as ready for review
October 1, 2026 17:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
eifinger/pywaze@v1.2.1...v1.2.3
Adds a fallback when 403 is encountered. The fallback uses curl-cffi to impersonate a chrome browser.
This is not chosen as the default as I hope that the 403 errors will go away on its own, being caused by a misconfiguration on Waze's backend.
In addition to the version bump we need to close the new curl-cffi client when unloading/reloading the integration and in single-use locations to avoid resource leaks.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: