{{ message }}
Repository navigation
Allow the none reasoning effort for GPT-6 Luna - #183922
Merged
zweckj merged 1 commit intoOct 1, 2026
Merged
Conversation
Contributor
Contributor
|
Hey there @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused model exception is consistent with existing prefix handling and has comprehensive regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Adds GPT-6 Luna-specific reasoning options to the OpenAI Conversation integration.
Changes:
- Allows
nonereasoning effort while retaininglowas default. - Tests Conversation and AI Task configuration persistence.
- Verifies generated Responses API arguments with snapshots.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Matos182
marked this pull request as ready for review
October 1, 2026 16:35
zweckj
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breaking change
Proposed change
gpt-6-lunasupports thenonereasoning effort, but the configuration flow uses the general GPT-6 list, which does not include it. This means users cannot selectnonewhen configuring the model.This change adds a
gpt-6-lunaentry before the generalgpt-6entry. It allowsnonein both Conversation and AI Task subentries and keepslowas the default.The supported effort levels are listed in the OpenAI model documentation.
How to reproduce
gpt-6-luna.noneis missing.Tests
The tests cover the effort list, saving
noneandlowfor both subentry types, and the Responses API arguments for both settings.config_flow.py.prekhooks passed for the four changed files.none, the API also acceptedtemperature=0.5andtop_p=0.9. These checks used no Home Assistant device data or actions.Integration test command:
Local validation limits
I used Python 3.14.5 and the dependencies pinned by Core, including the test requirements and OpenAI SDK.
The full
script/setupstopped while building DTLSSocket becauseautoconfwas unavailable. I installed the dependencies needed for the integration and ran the tests and checks above.The repository-wide
prek run --all-fileswas stopped when pylint exhausted the available memory. Running the remaining hooks reported a duplicate-module conflict forsignal_type.py/.pyiin mypy and a missinginfrared_protocolsdependency in hassfest. The checks on the changed files passed, but I could not complete all repository-wide checks locally.This PR adds no dependencies or configuration keys. The model-switch effort reset discussed in #182222 is outside its scope.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: