issue_schema: Add optional short_title translations by wendevlin · Pull Request #183883 · home-assistant/core · GitHub
Skip to content

issue_schema: Add optional short_title translations - #183883

Merged
silamon merged 1 commit into
devfrom
issue-short-title
Oct 2, 2026
Merged

silamon merged 1 commit into
devfrom
issue-short-title

Conversation

@wendevlin

@wendevlin wendevlin commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Proposed change

Sometime repair issues causes too long dialog titles in frontend.
Frontend could wrap the title but that would destroy the styles, so a more elegant soltuion is to introduce short_title to show in the dialog title.
title is still used for the summary.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI balanced review requested due to automatic review settings October 1, 2026 10:47
@home-assistant

home-assistant Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Frontend-handled repair issues still reject the new optional field.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Adds optional short repair-issue titles to prevent oversized frontend dialog headings.

Changes:

  • Extends the repair translation schema with short_title.
  • Adds short titles for automation validation failures.
  • Updates schema validation coverage.
File Description
script/​hassfest/​translations.py Allows short issue titles.
tests/​hassfest/​test_translations.py Covers the new schema field.
homeassistant/​components/​automation/​strings.json Adds short automation repair titles.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread script/hassfest/translations.py
@silamon
silamon merged commit 4357b39 into dev Oct 2, 2026
55 checks passed
@silamon
silamon deleted the issue-short-title branch October 2, 2026 07:51
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants