{{ message }}
Repository navigation
Report read-only climate entities as such to Google Assistant - #183820
Merged
frenck merged 2 commits intoOct 5, 2026
Merged
Conversation
home-assistant
Bot
added
bugfix
cla-signed
core
Hacktoberfest
has-tests
integration: google_assistant
small-pr
Contributor
RReverser
force-pushed
the
google-assistant-query-only-climate
branch
from
October 1, 2026 00:09
8485e24 to
62fd69c
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The no-mode path emits an invalid empty mode list, and the PR description omits required template entries.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Reports read-only climate entities correctly to Google Assistant.
Changes:
- Adds query-only detection based on setpoint and mode capabilities.
- Adds coverage for controllable and query-only climates.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PR home-assistant#173033 introduced template climate entities, which have no temperature control unless a `set_temperature` action is configured. Today, those with at most one HVAC mode would show up in Google Home as controllable thermostats, and any change made there would fail. This PR fixes that by setting `queryOnlyTemperatureSetting` on climate entities that support neither `TARGET_TEMPERATURE` nor `TARGET_TEMPERATURE_RANGE` and have at most one HVAC mode, so there is nothing for Google to control. Entities with two or more modes stay controllable, since `TemperatureSettingTrait` also switches modes. The fallback `heat` mode for entities without modes exists only so Google allows setting a temperature, so it is no longer added to entities without a setpoint. home-assistant#173033 https://developers.home.google.com/cloud-to-cloud/traits/temperaturesetting
RReverser
force-pushed
the
google-assistant-query-only-climate
branch
from
October 1, 2026 10:10
62fd69c to
1f6afbd
Compare
frenck
approved these changes
Oct 5, 2026
frenck
left a comment
frenck
left a comment
Member
There was a problem hiding this comment.
Oh hi there @RReverser 👋
My review notes: (this space intentionally left blank). Thanks for the pull request!
By the way, congratulations on your first contribution to Home Assistant! Welcome aboard 🎉
../Frenck
Blogging my personal ramblings at frenck.dev
Here is a picture of a dog for you:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
PR #173033 introduced template climate entities, which have no temperature control unless a
set_temperatureaction is configured. Today, they would show up in Google Home as controllable thermostats, and any change made there would fail.This PR fixes that by setting
queryOnlyTemperatureSettingon climate entities that support neitherTARGET_TEMPERATUREnorTARGET_TEMPERATURE_RANGEand have at most one HVAC mode, so there is nothing for Google to control. Entities with two or more modes stay controllable, sinceTemperatureSettingTraitalso switches modes.The fallback
heatmode for entities without modes exists only so Google allows setting a temperature, so it is no longer added to entities without a setpoint.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: