{{ message }}
Repository navigation
Fix Supervisor connection leak when leaving an app's log page - #183772
Merged
agners merged 2 commits intoOct 1, 2026
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix correctly handles cancellation and includes appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes leaked Supervisor connections when log streaming is cancelled.
Changes:
- Releases Supervisor responses in all completion paths.
- Adds cancellation regression coverage.
| File | Description |
|---|---|
homeassistant/components/hassio/http.py |
Releases upstream responses in finally. |
tests/components/hassio/test_http.py |
Verifies release after stream cancellation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
agners
requested changes
Oct 1, 2026
agners
left a comment
Member
There was a problem hiding this comment.
Nice catch, thanks for the PR! We can make it a bit prettier (and technically slightly better) by using async context manager.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed change
Leaving an app's log page, or reloading it, makes the frontend abort its
logs/followstream. The handler inHassIOViewgets cancelled, but the response from the Supervisor never gets released, so its connection stays in use until Core restarts.Most of the time that's fine, since aiohttp releases the connection by itself once the body has been fully read. A follow stream never finishes though, and
NO_TIMEOUTgives it no total timeout. So each visit to a log page leaks a connection, and after 100 of them every Supervisor call times out: the apps page won't load and ingress panels just hang.The fix opens the request with async with, so the response is released when the handler exits, including when it's cancelled. The test helper's mock response now releases on exit too, like aiohttp's.
I added a test that cancels the stream partway through and checks the response gets released. It fails on
devwithout this change.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: