{{ message }}
Foundation: Java 21 baseline + migration status#24
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
Foundation: Java 21 baseline + migration status#24devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: hitomi.sawamura@gmail.com <hitomi.sawamura@gmail.com>
… issues Co-Authored-By: hitomi.sawamura@gmail.com <hitomi.sawamura@gmail.com>
Co-Authored-By: hitomi.sawamura@gmail.com <hitomi.sawamura@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR establishes the Java 21 foundation for Apache CloudStack 4.22.0.0. From a single instruction, the migration was analyzed across 7,655 Java files in 13 modules, the JDK version was bumped, a sandbox build was verified, test compatibility was checked (discovering a critical cglib blocker), and CI workflows were updated.
Changes:
cs.jdk.version11 → 21 in rootpom.xmlbuild.ymlJDK 17 → 21;trigger-package-and-publish.ymlApache license header added + trailing whitespace fixedJAVA_21_MIGRATION_STATUS.mdwith module-by-module analysis, deprecated API inventory (9 categories, 1,775+ files affected), and critical blocker documentationKey finding:
cglib-nodep 3.3.0(unmaintained since 2019) causesUnsupported class file major version 65errors in 64+ DAO test classes. Migration to ByteBuddy is required before full test suite passes.Sandbox verification:
VMInstanceDaoImplTest— 18/18 errors due to cglib incompatibilityTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
BUILD SUCCESS with JDK 21 (25 modules):

Test compatibility check — cglib blocker discovered:

How Has This Been Tested?
mvn install -DskipTests -Dcheckstyle.skip=true -pl server -amwith JDK 21 — BUILD SUCCESS (25 modules)mvn test -pl engine/schema -Dtest=VMInstanceDaoImplTest— confirmed cglib blocker (18 errors, major version 65)How did you try to break this feature and the system with this change?
Ran targeted test against the most critical module (
engine/schema) to verify JDK 21 compatibility at the test level. Discovered and documented the cglib-nodep blocker that affects 64+ test classes across the DAO layer.Link to Devin session: https://app.devin.ai/sessions/fced28320b1b46e2a2f93e712c14677d
Requested by: @hitomimimi