feat!: remove deprecated backup window flag by phm07 · Pull Request #710 · hetznercloud/cli · GitHub
Skip to content

feat!: remove deprecated backup window flag - #710

Draft
phm07 wants to merge 1 commit into
mainfrom
remove-backup-window
Draft

phm07 wants to merge 1 commit into
mainfrom
remove-backup-window

Conversation

@phm07

@phm07 phm07 commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

This flag has been deprecated (and not working) since 2018: #147

@phm07 phm07 self-assigned this Mar 7, 2024
@codecov

codecov Bot commented Mar 7, 2024 •

Copy link
Copy Markdown

@jooola jooola changed the title fix: remove deprecated backup window flag feat: remove deprecated backup window flag Mar 7, 2024
@apricote apricote changed the title feat: remove deprecated backup window flag feat!: remove deprecated backup window flag Mar 8, 2024
@apricote apricote added this to the v2 milestone Mar 12, 2024
@apricote

Copy link
Copy Markdown
Member

This is a potentially breaking change. Even though this flag shows a warning since 2018, we should try to avoid making breaking changes on purpose.

I have created a v2 milestone and added this PR to it, so we have a list of things to tackle if we decide to work on it.

@phm07
phm07 force-pushed the remove-backup-window branch from ca3dfd3 to 2bddf46 Compare May 23, 2024 12:45
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

@github-actions github-actions Bot added stale and removed stale labels Aug 21, 2024
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the stale label Nov 20, 2024
@jooola jooola added pinned and removed stale labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants