fix(storage): handle release names containing ".v" in the memory driver by sebxt · Pull Request #32782 · helm/helm · GitHub
Skip to content

fix(storage): handle release names containing ".v" in the memory driver - #32782

Open
sebxt wants to merge 1 commit into
helm:mainfrom
sebxt:fix/memory-driver-dotted-release-name
Open

sebxt wants to merge 1 commit into
helm:mainfrom
sebxt:fix/memory-driver-dotted-release-name

Conversation

@sebxt

@sebxt sebxt commented Oct 19, 2026

Copy link
Copy Markdown

What this PR does / why we need it:

The memory driver parsed storage keys with strings.Split(key, ".v") and required exactly two parts. Release names may contain dots, so a valid name such as my.vault or app.v2 made Get and Delete return release: invalid key, while Create and Query worked.

This moves the key parsing into a small helper that splits on the last .v and still validates that the suffix is a number. The same change is applied to the copy in internal/storage/driver.

Repro before the change:

HELM_DRIVER=memory HELM_MEMORY_DRIVER_DATA=rels.yaml helm get values my.vault --revision 1
Error: release: invalid key

Special notes for your reviewer:

Keys without a numeric version suffix are still rejected with ErrInvalidKey.

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

Fixes #32781

Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
@pull-request-size pull-request-size Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 19, 2026
@github-actions github-actions Bot added the v4.x Issues and Pull Requests related to the major version v4 label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. v4.x Issues and Pull Requests related to the major version v4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory storage driver rejects Get and Delete for release names containing ".v"

1 participant