add --extra-helm-args to ct lint by AndersBennedsgaard · Pull Request #552 · helm/chart-testing · GitHub
Skip to content

add --extra-helm-args to ct lint - #552

Merged
cpanato merged 1 commit into
helm:mainfrom
AndersBennedsgaard:feature/consolidate-args
Jul 10, 2023
Merged

cpanato merged 1 commit into
helm:mainfrom
AndersBennedsgaard:feature/consolidate-args

Conversation

@AndersBennedsgaard

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Makes it possible to pass extra Helm arguments to ct lint, such as --strict.

Which issue this PR fixes

Does not strictly fix, but helps with #166

@cpanato cpanato closed this Jul 6, 2023
@cpanato cpanato reopened this Jul 6, 2023
@cpanato

cpanato commented Jul 6, 2023

Copy link
Copy Markdown
Member

@cpanato

cpanato commented Jul 6, 2023

Copy link
Copy Markdown
Member

and need to generate the docs.

@AndersBennedsgaard

Copy link
Copy Markdown
Contributor Author

I completely forgot all about this PR. I have synced the two repos :)

and need to generate the docs.

Is there a way to auto-generate/-update docs (doc/ct_lint.md I guess?), or do I have to manually do this?

@cpanato

cpanato commented Jul 6, 2023

Copy link
Copy Markdown
Member

I completely forgot all about this PR. I have synced the two repos :)

and need to generate the docs.

Is there a way to auto-generate/-update docs (doc/ct_lint.md I guess?), or do I have to manually do this?

          go build -o ct-bin ./ct/main.go
          ./ct-bin doc-gen

also please do a rebase and remove the unnecessary commits, thanks

@AndersBennedsgaard

Copy link
Copy Markdown
Contributor Author

@cpanato does it look correct now? (I had some issues with rebasing, since I never use it)

Comment thread ct/cmd/root.go Outdated
Signed-off-by: AndersBennedsgaard <abbennedsgaard@gmail.com>

@cpanato cpanato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@hypery2k

Copy link
Copy Markdown

joejulian added a commit to joejulian/chart-testing that referenced this pull request Aug 16, 2023
joejulian added a commit to joejulian/chart-testing that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants