{{ message }}
Repository navigation
Merged
Conversation
fty4
changed the title
Member
closes #376 Signed-off-by: Marco Lecheler <marco@task.media> Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Signed-off-by: Marco Lecheler <marco@task.media> Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Signed-off-by: Marco Lecheler <marco@task.media> Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Contributor
Author
|
@cpanato I've updated the docs and forced-pushed the rebased commits. |
Member
|
this will be a breaking change for existing users, if they dont set the --target-branch in the config |
Contributor
Author
|
That is true - I already mentioned this in the PR body. New users will still have to specify the parameter if this will not be changed. |
joejulian
approved these changes
Aug 16, 2023
Member
|
when we release I will make a note in the release notes for this |
Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Signed-off-by: Marco Lecheler <marco@task.media>
odysseu
approved these changes
Sep 7, 2023
odysseu
approved these changes
Oct 4, 2023
|
LGTM 👍 |
This was referenced Oct 4, 2023
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
cpanato
changed the title
Member
|
Lgtm. We can maybe bump version number a bit to signal breaking change. |
davidkarlsen
approved these changes
Nov 19, 2023
Member
yes |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Because the default branch on GitHub is
mainand not longermasterthis should also be the default to chart-testing.Which issue this PR fixes:
fixes #376
Special notes for your reviewer:
BREAKING CHANGE:
If e.g an action or workflow is not using an explicit specified
target-branchthe job might will fail after this change.But after this change new users does not have the problem that a wrong branch is used.
For example I was suffering with the error message
exit status 128- see #330 because the default branch was notmain.