iframe-proxy

unguiculus · 2018-10-19T22:09:57Z

I built a first beta release on my own fork. For this initial release I put the focus on more or less keeping the same functionality, but configuration is much more flexible now. Once we get this merged, we can look at new features such as integrating additional tools like Kubeval or better reporting capabilities.

Please review and test.

https://github.com/unguiculus/chart-testing/releases/tag/v2.0.0-beta.0

@helm/charts-maintainers

scottrigby · 2018-10-21T01:19:59Z

rimusz · 2018-10-22T12:20:15Z

awesome work @unguiculus 👍 I will give a go for test

unguiculus · 2018-10-25T14:12:53Z

Here's a test PR that updates charts CI in order to demonstrate it works as expected:
helm/charts#8745

rimusz

would be nice to put to readme flags for lint, install, lint-and-install:

$ ./ct lint-and-install -h

Combines 'lint' and 'install' commands.

Usage:
  ct lint-and-install [flags]

Flags:
      --all                        Process all charts except those explicitly excluded.
                                   Disables changed charts detection and version increment checking
      --build-id string            An optional, arbitrary identifier that is added to the name of the namespace a
                                   chart is installed into. In a CI environment, this could be the build number or
                                   the ID of a pull request. If not specified, the name of the chart is used.
      --chart-dirs strings         Directories containing Helm charts (default [charts])
      --chart-repos strings        Additional chart repos to add so dependencies can be resolved
      --chart-yaml-schema string   The schema for chart.yml validation. If not specified, 'chart_schema.yaml'
                                   is searched in '/etc/ct', '$HOME/ct' and the current directory
      --charts strings             Specific charts to test.
                                   Disables changed charts detection and version increment checking
      --check-version-increment    Activates a check for chart version increments (default: true) (default true)
      --config string              Config file
      --excluded-charts strings    Charts that should be skipped
  -h, --help                       help for lint-and-install
      --lint-conf string           The config file for YAML linting. If not specified, 'lintconf.yaml' is
                                   searched in '/etc/ct', '$HOME/ct' and the current directory
      --remote string              The name of the Git remote used to identify changed charts (default "origin")
      --target-branch string       The name of the target branch used to identify changed charts (default "master")
      --tiller-namespace string    The namespace of Tiller (default: kube-system) (default "kube-system")
      --timeout duration           The timeout for Helm in seconds (default: 5m) (default 5m0s)
      --validate-maintainers       Enabled validation of maintainer account names in chart.yml (default: true).
                                   Works for GitHub, GitLab, and Bitbucket (default true)

So you do. to have to run commands yourself to check that out.

unguiculus · 2018-10-25T16:31:41Z

@rimusz I wasn't sure whether we should do that. I thought that might be too much. What does everyone else think?

rimusz · 2018-10-25T16:33:33Z

e.g. to add a folder docs and there to store more detailed info.

mattfarina

Nice job on the re-write. I like the direction. On the whole it LGTM. Because of the size I gave it a relatively fast review (~1 hour) for the size. There is a lot here.

mattfarina · 2018-10-30T17:57:10Z

+	CheckVersionIncrement bool          `mapstructure:"check-version-increment"`
+	ProcessAllCharts      bool          `mapstructure:"all"`
+	Charts                []string      `mapstructure:"charts"`
+	ChartRepos            []string      `mapstructure:"chart-repos"`


I see for the format for ChartRepos is incubator=https://incubator. Would it be more intuitive if those were broken up? Then the YAML would look something like:

chart-repos: - name: incubator location: https://incubator

All Cobra CLI flags are bound to Viper. This is generic. I guess changing this is not easily possible. And it would not be consistent.

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

* Add build.sh mac prerequisites, and README markdown linting fixes Signed-off-by: Scott Rigby <scott@r6by.com> * Update README.md Signed-off-by: Reinhard Nägele <unguiculus@gmail.com> Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

This reverts commit fcbfbdc. Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

unguiculus · 2018-11-06T17:16:09Z

Next beta: https://github.com/unguiculus/chart-testing/releases/tag/v2.0.0-beta.2

scottrigby · 2018-11-06T17:34:01Z

#35 (comment) and #35 (comment) have been addressed. README has been clarified on that point. File inclusion looks good in the new beta now too 💯

$ tree
.
├── LICENSE
├── README.md
├── ct
└── etc
    ├── chart_schema.yaml
    └── lintconf.yaml

1 directory, 5 files

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

mattfarina

This looks good to merge. Any future changes or fixes can come in smaller PRs.

Nicely done @unguiculus. This rewrite was a massive undertaking and you make it look easier than I could have.

prydonius

I had a very quick look through, and it's looking pretty solid to me. I'm not sure if you considered it, but we could import the Helm API for some of the structs we're using rather than duplicate them here, but that's a minor issue and we may want to have control over those structs here.

scottrigby · 2018-11-07T18:06:10Z

helm-bot added the size/XXL label Oct 19, 2018

unguiculus force-pushed the feature/go branch from f4130e1 to 4a4a0c5 Compare October 19, 2018 22:10

helm-bot added size/XXL and removed size/XXL labels Oct 19, 2018

unguiculus assigned mattfarina, scottrigby and rimusz Oct 19, 2018

unguiculus requested review from mattfarina, rimusz and scottrigby October 19, 2018 22:11

helm-bot added size/XXL and removed size/XXL labels Oct 25, 2018

rimusz reviewed Oct 25, 2018

View reviewed changes

mattfarina reviewed Oct 30, 2018

View reviewed changes

helm-bot added size/XXL and removed size/XXL labels Oct 30, 2018

unguiculus force-pushed the feature/go branch from aedd388 to 1272866 Compare October 30, 2018 22:12

helm-bot added size/XXL and removed size/XXL labels Oct 30, 2018

unguiculus force-pushed the feature/go branch from 1272866 to 16620fe Compare October 30, 2018 22:14

helm-bot added size/XXL and removed size/XXL labels Oct 30, 2018

unguiculus force-pushed the feature/go branch from 16620fe to f64ebc9 Compare October 30, 2018 22:14

helm-bot added size/XXL and removed size/XXL labels Oct 30, 2018

unguiculus and others added 2 commits November 6, 2018 17:10

Add Docker login

2a98dd5

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

Readme update for MacOS (#1)

b268fe5

* Add build.sh mac prerequisites, and README markdown linting fixes Signed-off-by: Scott Rigby <scott@r6by.com> * Update README.md Signed-off-by: Reinhard Nägele <unguiculus@gmail.com> Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

unguiculus force-pushed the feature/go branch from f73f280 to 123f678 Compare November 6, 2018 16:10

helm-bot added size/XXL and removed size/XXL labels Nov 6, 2018

unguiculus added 3 commits November 6, 2018 17:12

Update Gopkg.lock

fcbfbdc

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

Update config search locations

89daed7

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

Add config files to distro

5967230

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

unguiculus force-pushed the feature/go branch from 123f678 to 5967230 Compare November 6, 2018 16:12

helm-bot added size/XXL and removed size/XXL labels Nov 6, 2018

Merge remote-tracking branch 'upstream/master' into feature/go

776c2e9

helm-bot added size/XXL and removed size/XXL labels Nov 6, 2018

unguiculus added 5 commits November 6, 2018 17:46

Add debug flag

8ac16c4

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

Add note on config files for linting

c1ca521

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

Fix link

e495a73

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

Revert "Update Gopkg.lock"

923536f

This reverts commit fcbfbdc. Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

Fix link

212d9d5

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

scottrigby mentioned this pull request Nov 6, 2018

[test] Update chart testing helm/charts#8745

Merged

Fix readme

dca4635

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

mattfarina approved these changes Nov 6, 2018

View reviewed changes

prydonius approved these changes Nov 6, 2018

View reviewed changes

Comment thread pkg/util/util.go

unguiculus mentioned this pull request Nov 7, 2018

Proposal: Re-implement in Go #29

Closed

scottrigby mentioned this pull request Nov 8, 2018

Decide on and document supported versions #45

Closed

5 tasks done

philoserf mentioned this pull request Nov 28, 2018

How to pass bash array env vars #3

Closed

asherf mentioned this pull request Jun 15, 2019

[Tests] update docs, avoid redirect and fix dead link helm/charts#14828

Merged

1 task done

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

unguiculus commented Oct 19, 2018

Uh oh!

scottrigby commented Oct 21, 2018

Uh oh!

rimusz commented Oct 22, 2018

Uh oh!

unguiculus commented Oct 25, 2018

Uh oh!

rimusz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

unguiculus commented Oct 25, 2018

Uh oh!

rimusz commented Oct 25, 2018

Uh oh!

mattfarina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattfarina Oct 30, 2018 • edited by unguiculus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

unguiculus Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

unguiculus commented Nov 6, 2018

Uh oh!

scottrigby commented Nov 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattfarina left a comment

Choose a reason for hiding this comment

Uh oh!

prydonius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

scottrigby commented Nov 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rimusz left a comment •

edited

Loading

mattfarina Oct 30, 2018 •

edited by unguiculus

Loading

scottrigby commented Nov 6, 2018 •

edited

Loading