Add since flag for changing the reference branch for git merge-base by marc-sensenich · Pull Request #229 · helm/chart-testing · GitHub
Skip to content

Add since flag for changing the reference branch for git merge-base - #229

Merged
unguiculus merged 4 commits into
helm:masterfrom
marc-sensenich:gh-64-add-since-flag
Jul 24, 2020
Merged

unguiculus merged 4 commits into
helm:masterfrom
marc-sensenich:gh-64-add-since-flag

Conversation

@marc-sensenich

@marc-sensenich marc-sensenich commented Apr 21, 2020 •

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This adds a since flag that allows for the changing of the git reference for git merge-base. This is desired so that ct list-changed will allow for referencing the previous commit after a merge to master for CI/CD; for example

 ct list-changed --config .ct/config.yaml 
>>> git rev-parse --is-inside-work-tree
>>> git merge-base origin/master HEAD~1
>>> git diff --find-renames --name-only <commit> -- stable

Which issue this PR fixes
Closes #64

Special notes for your reviewer:
Closes #159 by picking up the work

Signed-off-by: Marc Sensenich <sensenichm91@gmail.com>
Signed-off-by: Marc Sensenich <sensenichm91@gmail.com>
Signed-off-by: Marc Sensenich <sensenichm91@gmail.com>
Signed-off-by: Marc Sensenich <sensenichm91@gmail.com>
@helm-bot helm-bot added size/S and removed size/XS labels Apr 21, 2020
@marc-sensenich marc-sensenich changed the title Add since flag for changing the reference branch for git merge-base Add since flag for changing the reference branch for git merge-base in v3 Apr 21, 2020
@marc-sensenich marc-sensenich changed the title Add since flag for changing the reference branch for git merge-base in v3 Add since flag for changing the reference branch for git merge-base in v3 Apr 21, 2020
@marc-sensenich marc-sensenich changed the title Add since flag for changing the reference branch for git merge-base in v3 Add since flag for changing the reference branch for git merge-base Apr 21, 2020
@unguiculus
unguiculus merged commit 93b10e8 into helm:master Jul 24, 2020
@marc-sensenich
marc-sensenich deleted the gh-64-add-since-flag branch July 24, 2020 20:26
@monotek

monotek commented Jul 25, 2020

Copy link
Copy Markdown
Contributor

unguiculus pushed a commit that referenced this pull request Aug 9, 2020
Signed-off-by: Marc Sensenich <sensenichm91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to git diff between last 2 local commits

5 participants