{{ message }}
Allow multiple assignees in NewIssue and EditIssue#336
Merged
phadej merged 5 commits intohaskell-github:masterfrom Feb 4, 2019
Merged
Allow multiple assignees in NewIssue and EditIssue#336phadej merged 5 commits intohaskell-github:masterfrom
phadej merged 5 commits intohaskell-github:masterfrom
Conversation
phadej
reviewed
Oct 25, 2018
Contributor
There was a problem hiding this comment.
is there difference between null/non-existing field (Nothing) and [] (empty Vector)?
Contributor
Author
There was a problem hiding this comment.
I believe sending [] causes all assignees to to be removed, and sending null causes errors from the server. See the notes for assignees on https://developer.github.com/v3/issues/#edit-an-issue
Contributor
Author
There was a problem hiding this comment.
I've confirmed that both an empty vector and having the keys missing are accepted by GitHub, so really it's a design question if you would prefer to send "assignees": [] or not.
Contributor
Author
|
Oh sorry, answering on my phone and missed the context - it looks as though sending [] would be fine, I'll fix that up tomorrow and test it. |
axman6
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #335
I'm not super familiar with
githubso don't know if there's obvious things I've missed, but these changes appear to work for our usage.