{{ message }}
Feature/get pull request patch#325
Closed
TomMD wants to merge 6 commits intohaskell-github:masterfrom
TomMD:feature/getPullRequestPatch
Closed
Feature/get pull request patch#325TomMD wants to merge 6 commits intohaskell-github:masterfrom TomMD:feature/getPullRequestPatch
TomMD wants to merge 6 commits intohaskell-github:masterfrom
TomMD:feature/getPullRequestPatch
Conversation
…e/createPullComment
Contributor
Author
Contributor
|
@TomMD thanks for the ping. Yes, I'll go through the PRs and make new release, let's see if this applies cleanly as is. |
phadej
reviewed
Feb 4, 2019
| -- See <https://developer.github.com/v3/pulls/#get-a-single-pull-request> | ||
| pullRequestDiffR :: Name Owner -> Name Repo -> Id PullRequest -> Request k ByteString | ||
| pullRequestDiffR user repo prid = | ||
| RawHeaderQuery |
Contributor
There was a problem hiding this comment.
is this header still required?
Contributor
There was a problem hiding this comment.
Ok. I see, we need this to get ByteString. I'd prefer a concrete sum type for Diff, Patch and sha from https://developer.github.com/v3/media/#commits-commit-comparison-and-pull-requests
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch target, much like the diff target, is accessible just by changing the header.