{{ message }}
fix(showcase): remove fixed grid rows to prevent layout stretching on devtools resize - #14
Merged
harshjdhv merged 1 commit intoJul 25, 2026
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe showcase section’s grid wrapper no longer applies ChangesShowcase layout
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the home showcase section (
data-home-showcase) expanded infinitely in height when toggling DevTools or resizing the viewport below 992px.Root Cause
The showcase grid wrapper had both
md:grid-rows-3andmd:auto-rows-[300px]applied simultaneously. When Framer Motion triggered thewhileInViewanimations upon viewport re-calculation (e.g., opening DevTools), implicit grid items exceeded the fixed row bounds, causing continuous element layout recalculations and breaking regular page scrolling.Changes Made
md:grid-rows-3from the showcase<motion.div>grid container.md:auto-rows-[300px].How to Reproduce the Issue
data-home-showcasesectionSummary by CodeRabbit