Add msg direction for CAN-FD in BlfReader by fabiocrestani · Pull Request #966 · hardbyte/python-can · GitHub
Skip to content

Add msg direction for CAN-FD in BlfReader#966

Merged
mergify[bot] merged 5 commits into
hardbyte:developfrom
fabiocrestani:bugfix/blf-reader-missing-direction-of-can-fd
Jun 8, 2021
Merged

Add msg direction for CAN-FD in BlfReader#966
mergify[bot] merged 5 commits into
hardbyte:developfrom
fabiocrestani:bugfix/blf-reader-missing-direction-of-can-fd

Conversation

@fabiocrestani

Copy link
Copy Markdown
Contributor

Fixes #965

@mergify mergify Bot requested a review from hardbyte January 8, 2021 11:41

@hardbyte hardbyte left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@hardbyte

Copy link
Copy Markdown
Owner

@felixdivo

Copy link
Copy Markdown
Collaborator

Is someone planning to adjust the failing test.logformats_test.TestBlfFileFormat.test_can_fd_message_64 test?

@felixdivo felixdivo added the bug label Apr 14, 2021
@felixdivo felixdivo added the file-io about reading & writing to files label Apr 26, 2021
@felixdivo felixdivo added this to the 4.0.0 Release milestone Apr 26, 2021
@felixdivo

felixdivo commented Jun 5, 2021

Copy link
Copy Markdown
Collaborator

It would be great to get this included in the 4.0.0 release, but one would have to very slightly change the testing code.

See here: https://travis-ci.com/github/hardbyte/python-can/jobs/469807838#L898

@fabiocrestani

Copy link
Copy Markdown
Contributor Author

I fixed the test and now everything should pass :)

@codecov

codecov Bot commented Jun 8, 2021

Copy link
Copy Markdown

@mergify mergify Bot merged commit 3b85b88 into hardbyte:develop Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug file-io about reading & writing to files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BLF reader is missing direction of CAN FD Message

5 participants