{{ message }}
Adding CAN FD 64 frame support to blf reader#568
Merged
Conversation
felixdivo
reviewed
May 3, 2019
felixdivo
reviewed
May 3, 2019
| bitrate_switch=bool(fd_flags & BRS_64), | ||
| error_state_indicator=bool(fd_flags & ESI_64), | ||
| dlc=length, | ||
| data=can_data[:length], |
Collaborator
There was a problem hiding this comment.
It would probably be more efficient something like this instead of unpacking the raw data above:
data_offset = pos + CAN_FD_MSG_64_STRUCT.size
data[data_offset:data_offset + length]Also I've realized it should really be the valid payload length and not the DLC to support remote frames correctly, but it is more of a sanity thing.
Collaborator
|
Could we add such a CAN FD 64 frame to |
Collaborator
|
The test file was copied from Toby’s C++ library. Maybe we should create our own and check that it is correct in a Vector application. I however do not have access to one anymore. |
Collaborator
|
Okay, so maybe just open a new issue for that and merge this PR? |
christiansandberg
approved these changes
May 13, 2019
christiansandberg
left a comment
christiansandberg
left a comment
Collaborator
There was a problem hiding this comment.
Sound good to me!
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.