Keep Track of Active Notifiers. Make Notifier usable as ContextManager.#1890
Conversation
This would make things a bit more complicated.
However, a What kind of solution did you have in mind? |
This would be great! If I understand correctly, without such a classmethod this PR in its current state does not solve the example I put forth in #1888 (comment). A |
e06fc55 to
e35610a
Compare
|
|
||
| :param bus: A :ref:`bus` or a list of buses to listen to. | ||
| :param bus: | ||
| A :ref:`bus` or a list of buses to listen to. |
There was a problem hiding this comment.
| A :ref:`bus` or a list of buses to listen to. | |
| A :ref:`bus` or a list of buses to consume messages from. |
There was a problem hiding this comment.
self._bus_list won't be correct after a user adds an additional Bus via add_bus, instead prefer to create an empty bus list here in the initializer, but add them inside the add_bus method.
There was a problem hiding this comment.
Good catch. The same was true for self.bus, i changed that to a property.
f9095a0 to
1708dda
Compare

Notifier.stop(). Adapt examples to usewith can.Notifier(...)