{{ message }}
Adding worker_thread_idle() for more informative profiling#8719
Merged
Conversation
Contributor
Author
mcourteaux
approved these changes
Aug 13, 2025
mcourteaux
left a comment
mcourteaux
left a comment
Contributor
There was a problem hiding this comment.
The calling overhead seems fine, as it's in idle circumstances.
alexreinking
added
the
code_cleanup
abadams
reviewed
Aug 15, 2025
Contributor
Author
|
Are we good on merging this? |
Contributor
Author
alexreinking
approved these changes
Aug 20, 2025
alexreinking
left a comment
alexreinking
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I say merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small cosmetic change to assist during profiling (make it clear when the worker threads are idling).