Add support for arm64e (Fixes #4490) by steven-johnson · Pull Request #8330 · halide/Halide · GitHub
Skip to content

Add support for arm64e (Fixes #4490)#8330

Draft
steven-johnson wants to merge 8 commits into
mainfrom
srj/arm64e
Draft

Add support for arm64e (Fixes #4490)#8330
steven-johnson wants to merge 8 commits into
mainfrom
srj/arm64e

Conversation

@steven-johnson

Copy link
Copy Markdown
Contributor

No description provided.

@steven-johnson steven-johnson marked this pull request as ready for review June 27, 2024 00:17

@alexreinking alexreinking left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Python enum values?

@alexreinking alexreinking left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. Mobile is dumb.

@abadams

abadams commented Jun 27, 2024

Copy link
Copy Markdown
Member

@steven-johnson

Copy link
Copy Markdown
Contributor Author

Does it pass the checks it injects though?

No idea. Still testing. Converting back to draft for now.

@steven-johnson steven-johnson marked this pull request as draft June 27, 2024 15:43
@steven-johnson

Copy link
Copy Markdown
Contributor Author

Last time we talked about this I thought there was going to be a problem around our use of function pointers because indirect branches need special treatment.

Did we talk about this before? I've apparently flushed those memories.

It looks almost impossible to test on macos: (https://stackoverflow.com/questions/75186888/how-to-enable-the-arm-pointer-authentication-code-pac-on-macos)

That's likely gonna rule me out for testing anything, then (at least in the short term) because I don't possess any iDevices, nor can I get any in the next couple of days.

Is this something that anyone at Adobe has the bandwidth or expertise to look into in the short term? I hate to punt something after seeing that it's hard to do, but I'm about to take two weeks vacation, and if this is something that might be resolvable by someone who won't be starting from ground zero on iOS it would be a big favor (I haven't even attempted to build/debug/etc for an iDevice pre-pandemic, at least)

@steven-johnson steven-johnson changed the title Add support for arm64e Add support for arm64e (Fixes #4490) Jun 27, 2024
@steven-johnson

Copy link
Copy Markdown
Contributor Author

This appears to be a good overview of arm64e: https://github.com/lelegard/arm-cpusysregs/blob/main/docs/arm64e-on-macos.md

@steven-johnson

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants