{{ message }}
Parallelize some tests#8078
Merged
Merged
Conversation
This reduces the time taken to run all correctness tests from 8:15 to 3:15 on my machine.
Member
Author
Contributor
|
No, unfortunately. ASAN can be weird sometimes. I could try pulling this into google3 and testing there. |
We don't have a custom error handler in place, so they're always zero
steven-johnson
approved these changes
Feb 12, 2024
Contributor
There was a problem hiding this comment.
What's with this change?
Member
Author
There was a problem hiding this comment.
Accidental commit. Will revert.
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Parallelize some tests This reduces the time taken to run all correctness tests from 8:15 to 3:15 on my machine. * The FIXME is actually fine * Remove debug print * Fix when we're willing to run x86 code in simd_op_check * Use separate imageparams per task * Deep-copy the LoopLevels * Make float16_t neon op check test at least build * Revert accidental serialization * Throw return values from callable into the void We don't have a custom error handler in place, so they're always zero * Skip test under ASAN * Fix unintentional change to test
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the time taken to run all correctness tests from 8:15 to 3:15 on my machine.
It composes reasonably well with test sharding, but it's a bit weird that both mechanisms exist.
simd_op_check needed some reworking to avoid shared state between the threads.