{{ message }}
[CMake] Deduplicate Halide_LLVM_VERSION and LLVM_PACKAGE_VERSION#6646
Merged
alexreinking merged 1 commit intoMar 16, 2022
Merged
Conversation
As far as i can tell, they are always exactly identical, and i don't believe the claim that `LLVM_PACKAGE_VERSION` doesn't exist in upper scopes is valid.
Member
Contributor
Author
I don't follow at all, but you already rely on
I mean, can you point me at the other uses? |
Member
alexreinking
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as i can tell, they are always exactly identical,
and i don't believe the claim that
LLVM_PACKAGE_VERSIONdoesn't exist in upper scopes is valid.