{{ message }}
Python Bindings didn't allow for zero-D Funcs, ImageParams, Buffers#6633
Merged
Conversation
There were no overloads or tests for accessing the element of any of these in the zero-D case, and the obvious syntax (`[]`, to mirror C++ `()` in these cases) isn't legal in Python. To support this uncommon-but-necessary case, I'm proposing that we use the syntax `[None]`, which isn't pretty, but is less bad than other options I've considered so far. (Suggestions welcome.)
steven-johnson
added
the
release_notes
alexreinking
approved these changes
Mar 3, 2022
Member
Member
|
|
Contributor
Author
|
FWIW, |
Contributor
Author
|
Final votes on syntax? |
Member
On second thought, we shouldn't use https://numpy.org/doc/stable/reference/constants.html#numpy.newaxis |
Contributor
Author
alexreinking
approved these changes
Mar 4, 2022
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were no overloads or tests for accessing the element of any of these in the zero-D case, and the obvious syntax (
[], to mirror C++()in these cases) isn't legal in Python. To support this uncommon-but-necessary case, I'm proposing that we use the syntax[None][()], which isn't pretty, but is less bad than other options I've considered so far. (Suggestions welcome.)