filesystem.hpp, add support for Haiku by Begasus · Pull Request #163 · gulrak/filesystem · GitHub
Skip to content

filesystem.hpp, add support for Haiku - #163

Merged
gulrak merged 2 commits into
gulrak:masterfrom
Begasus:haiku
Feb 20, 2023
Merged

filesystem.hpp, add support for Haiku#163
gulrak merged 2 commits into
gulrak:masterfrom
Begasus:haiku

Conversation

@Begasus

@Begasus Begasus commented Feb 18, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@Begasus

Begasus commented Feb 18, 2023

Copy link
Copy Markdown
Contributor Author

@jessicah

Copy link
Copy Markdown

https://github.com/gulrak/filesystem/blob/master/cmake/GhcHelper.cmake#L48

Add something like:

if (HAIKU)
  target_link_libraries(${targetName} -lnetwork)
endif()

@jessicah

Copy link
Copy Markdown

You may also need for the second macro, depends which part(s) require libnetwork.

@Begasus

Begasus commented Feb 19, 2023

Copy link
Copy Markdown
Contributor Author

@jessicah thanks for the tip, following the fix for Solaris I managed to get a full build. :) patch comming in later :)

91e71f7

@jmairboeck jmairboeck left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few style comments.

They apply multiple times, I didn't repeat them.

Comment thread cmake/GhcHelper.cmake Outdated
Comment thread cmake/GhcHelper.cmake Outdated
@Begasus

Begasus commented Feb 19, 2023

Copy link
Copy Markdown
Contributor Author

Should be OK now, did a clean build on Haiku with this PR as a patch, ran the tests (95% passed), only thing I'm missing is an option to disable Werror, but got a fix for that from Gentoo: https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-cpp/gulrak-filesystem/gulrak-filesystem-1.5.12.ebuild#n22

@Begasus

Begasus commented Feb 19, 2023

Copy link
Copy Markdown
Contributor Author

Would be nice if this gets merged before a new release: #164 :)

Created a PR at haikuports to have this available on Haiku: haikuports/haikuports#7865

@gulrak

gulrak commented Feb 19, 2023

Copy link
Copy Markdown
Owner

@gulrak
gulrak merged commit bc05cc5 into gulrak:master Feb 20, 2023
@Begasus
Begasus deleted the haiku branch February 20, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants