Disable ``deprecated-declarations`` warning in tests (C++20) by phprus · Pull Request #140 · gulrak/filesystem · GitHub
Skip to content

Disable deprecated-declarations warning in tests (C++20) - #140

Merged
gulrak merged 2 commits into
gulrak:masterfrom
phprus:cxx20-deprecated
Apr 2, 2022
Merged

Disable deprecated-declarations warning in tests (C++20)#140
gulrak merged 2 commits into
gulrak:masterfrom
phprus:cxx20-deprecated

Conversation

@phprus

@phprus phprus commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

Build errors (C++20 build):

phprus@mbp cxx20 % cmake -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=20 ../..
-- The C compiler identification is AppleClang 13.0.0.13000029
-- The CXX compiler identification is AppleClang 13.0.0.13000029
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- CMAKE_CXX_COMPILE_FEATURES: cxx_std_98;cxx_template_template_parameters;cxx_std_11;cxx_alias_templates;cxx_alignas;cxx_alignof;cxx_attributes;cxx_auto_type;cxx_constexpr;cxx_decltype;cxx_decltype_incomplete_return_types;cxx_default_function_template_args;cxx_defaulted_functions;cxx_defaulted_move_initializers;cxx_delegating_constructors;cxx_deleted_functions;cxx_enum_forward_declarations;cxx_explicit_conversions;cxx_extended_friend_declarations;cxx_extern_templates;cxx_final;cxx_func_identifier;cxx_generalized_initializers;cxx_inheriting_constructors;cxx_inline_namespaces;cxx_lambdas;cxx_local_type_template_args;cxx_long_long_type;cxx_noexcept;cxx_nonstatic_member_init;cxx_nullptr;cxx_override;cxx_range_for;cxx_raw_string_literals;cxx_reference_qualified_functions;cxx_right_angle_brackets;cxx_rvalue_references;cxx_sizeof_member;cxx_static_assert;cxx_strong_enums;cxx_thread_local;cxx_trailing_return_types;cxx_unicode_literals;cxx_uniform_initialization;cxx_unrestricted_unions;cxx_user_literals;cxx_variadic_macros;cxx_variadic_templates;cxx_std_14;cxx_aggregate_default_initializers;cxx_attribute_deprecated;cxx_binary_literals;cxx_contextual_conversions;cxx_decltype_auto;cxx_digit_separators;cxx_generic_lambdas;cxx_lambda_init_captures;cxx_relaxed_constexpr;cxx_return_type_deduction;cxx_variable_templates;cxx_std_17;cxx_std_20
Generating test runner for normal test...
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/phprus/Devel/gulrak/filesystem/build/cxx20
phprus@mbp cxx20 %

.....

[  5%] Building CXX object test/CMakeFiles/filesystem_test.dir/filesystem_test.cpp.o
cd /Users/phprus/Devel/gulrak/filesystem/build/cxx20/test && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -I/Users/phprus/Devel/gulrak/filesystem/include -O3 -DNDEBUG -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk -Wall -Wextra -Wshadow -Wconversion -Wsign-conversion -Wpedantic -Werror -std=gnu++2a -MD -MT test/CMakeFiles/filesystem_test.dir/filesystem_test.cpp.o -MF CMakeFiles/filesystem_test.dir/filesystem_test.cpp.o.d -o CMakeFiles/filesystem_test.dir/filesystem_test.cpp.o -c /Users/phprus/Devel/gulrak/filesystem/test/filesystem_test.cpp
/Users/phprus/Devel/gulrak/filesystem/test/filesystem_test.cpp:607:15: error: 'u8path<char [7], ghc::filesystem::path>' is deprecated: use ghc::filesystem::path::path() with std::u8string instead [-Werror,-Wdeprecated-declarations]
    CHECK(fs::u8path("\xc3\xa4/\xe2\x82\xac").native() == fs::path::string_type("\xc3\xa4/\xe2\x82\xac"));
              ^
/Users/phprus/Devel/gulrak/filesystem/include/ghc/filesystem.hpp:640:3: note: 'u8path<char [7], ghc::filesystem::path>' has been explicitly marked deprecated here
[[deprecated("use ghc::filesystem::path::path() with std::u8string instead")]]
  ^
....
              ^
/Users/phprus/Devel/gulrak/filesystem/include/ghc/filesystem.hpp:640:3: note: 'u8path<char [7], ghc::filesystem::path>' has been explicitly marked deprecated here
[[deprecated("use ghc::filesystem::path::path() with std::u8string instead")]]
  ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [test/CMakeFiles/filesystem_test.dir/filesystem_test.cpp.o] Error 1
make[1]: *** [test/CMakeFiles/filesystem_test.dir/all] Error 2
make: *** [all] Error 2
make  0,91s user 0,04s system 98% cpu 0,968 total
phprus@mbp cxx20 %

@gulrak gulrak added this to the 1.5.12 milestone Apr 2, 2022
@gulrak gulrak added the enhancement New feature or request label Apr 2, 2022
@gulrak

gulrak commented Apr 2, 2022

Copy link
Copy Markdown
Owner

@gulrak
gulrak merged commit 5d1d579 into gulrak:master Apr 2, 2022
@phprus
phprus deleted the cxx20-deprecated branch April 16, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants