Fix for issue #132 by phprus · Pull Request #135 · gulrak/filesystem · GitHub
Skip to content

Fix for issue #132 - #135

Merged
gulrak merged 2 commits into
gulrak:masterfrom
phprus:issue-132
Oct 1, 2021
Merged

Fix for issue #132#135
gulrak merged 2 commits into
gulrak:masterfrom
phprus:issue-132

Conversation

@phprus

@phprus phprus commented Sep 22, 2021

Copy link
Copy Markdown
Contributor

Fix ghc::filesystem::remove_all behavior if argument is symlink (#132)
See https://en.cppreference.com/w/cpp/filesystem/remove:

Symlinks are not followed (symlink is removed, not its target).

Update CI: Switch from ubuntu 16.04 to 18.04

@phprus

phprus commented Sep 28, 2021

Copy link
Copy Markdown
Contributor Author

@gulrak

gulrak commented Oct 1, 2021

Copy link
Copy Markdown
Owner

Sorry, I had some very busy weeks at my job. Thank you for this fix and for the CI update to 18.04!

@phprus

phprus commented Oct 1, 2021

Copy link
Copy Markdown
Contributor Author

I apologize for distracting you from your job.

@gulrak

gulrak commented Oct 1, 2021

Copy link
Copy Markdown
Owner

@phprus
phprus deleted the issue-132 branch April 16, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants