using static_cast instead of old style cast by philbucher · Pull Request #108 · gulrak/filesystem · GitHub
Skip to content

using static_cast instead of old style cast - #108

Merged
gulrak merged 1 commit into
gulrak:masterfrom
philbucher:patch-1
Mar 19, 2021
Merged

using static_cast instead of old style cast#108
gulrak merged 1 commit into
gulrak:masterfrom
philbucher:patch-1

Conversation

@philbucher

Copy link
Copy Markdown
Contributor

This is a warning in GCC when using -Wold-style-cast

This is a warning in GCC when using -Wold-style-cast
@philbucher

Copy link
Copy Markdown
Contributor Author

@gulrak

gulrak commented Mar 19, 2021

Copy link
Copy Markdown
Owner

Hi, thank you for the PR, indeed I didn't want to hide warnings, as I prefer to change to code to avoid them. Those old-style casts are a result of copying code from an old tooling file of mine and I should have replaced them, so thanks for fixing it.

@gulrak
gulrak merged commit b8cff0c into gulrak:master Mar 19, 2021
@philbucher
philbucher deleted the patch-1 branch March 22, 2021 11:37
@philbucher

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants