Improved string_view support by phprus · Pull Request #102 · gulrak/filesystem · GitHub
Skip to content

Improved string_view support - #102

Merged
gulrak merged 1 commit into
gulrak:masterfrom
phprus:string_view
Feb 20, 2021
Merged

Improved string_view support#102
gulrak merged 1 commit into
gulrak:masterfrom
phprus:string_view

Conversation

@phprus

@phprus phprus commented Feb 16, 2021

Copy link
Copy Markdown
Contributor
  1. Removed use of the __cpp_lib_string_view macro, because the __cpp_lib_string_view macro requires <version>(C++20) or <string_view> (In the libc++: only since version 8.0: llvm/llvm-project@f56972e)
  2. Added support of legacy std::experimental::string_view (if the std::string_view not found).
  3. Added selector to use a custom, user provided string_view implementation (by defining the GHC_HAS_USER_STRING_VIEW macro and add using custom::basic_string_view into ghc::filesystem namespace).

Maybe the GHC_HAS_USER_STRING_VIEW macro should be renamed?

@gulrak

gulrak commented Feb 17, 2021

Copy link
Copy Markdown
Owner

@gulrak gulrak added the enhancement New feature or request label Feb 17, 2021
@phprus

phprus commented Feb 17, 2021

Copy link
Copy Markdown
Contributor Author

@gulrak gulrak added this to the v1.5.2 milestone Feb 17, 2021
@gulrak
gulrak merged commit 0e5f2f5 into gulrak:master Feb 20, 2021
@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Feb 20, 2021
@phprus
phprus deleted the string_view branch April 16, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

available on master Fix is done on master branch, issue closed on next release enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants