Export the database security group from the editions stack by davidfurey · Pull Request #2149 · guardian/facia-tool · GitHub
Skip to content

Export the database security group from the editions stack - #2149

Merged
davidfurey merged 1 commit into
mainfrom
cleanup/9-export-database-security-group
Oct 22, 2026
Merged

davidfurey merged 1 commit into
mainfrom
cleanup/9-export-database-security-group

Conversation

@davidfurey

@davidfurey davidfurey commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Note

This PR was opened by Claude Opus 5 based on an interactive session but I have reviewed the output

Exports the fronts database's security group id from facia-db-<stage> so that facia-<stage> can import it instead of carrying it as the DBSecurityGroupIdNewVPC CloudFormation parameter.

We are splitting out the export and import into two PRs to support testing and rollback.

Deployment:

Roll-back:

  • Deploy a build that includes the export but doesn't use it
  • Deploy a build that doesn't include the export

@davidfurey davidfurey added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Oct 21, 2026
@davidfurey
davidfurey marked this pull request as ready for review October 21, 2026 16:35
@davidfurey
davidfurey requested a review from a team as a code owner October 21, 2026 16:35
@waisingyiu waisingyiu self-assigned this Oct 22, 2026

@waisingyiu waisingyiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Not sure if it was changed, but I seem to remember that AWS cannot create a change set if the only change to the stack is "Exports". So we may need to manually check whether the security group ID has really been exported.

@davidfurey

Copy link
Copy Markdown
Member Author

Deploying this via Riff-Raff does not work, because riff-raff sees no change in the changeset so does not apply the changeset. Creating a changeset manually and applying it does work, the export is created.

@davidfurey
davidfurey merged commit ffa8881 into main Oct 22, 2026
14 checks passed
@davidfurey
davidfurey deleted the cleanup/9-export-database-security-group branch October 22, 2026 13:04
@gu-prout

gu-prout Bot commented Oct 22, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @davidfurey 7 minutes and 10 seconds ago) Please check your changes!

@davidfurey

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants