{{ message }}
Repository navigation
Puzzles hub: banner spacing at leftCol/wide and mobile card separators - #16953
Open
andresilva-guardian wants to merge 5 commits into
Open
andresilva-guardian wants to merge 5 commits into
andresilva-guardian wants to merge 5 commits into
Conversation
…ry, and PuzzlesSupporting components for consistency and improved layout
…r improved layout consistency
andresilva-guardian
added
run_chromatic
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:c0441754776e698cf7abd35e1c9c137a1b28d2e56822982e3ced6f18de79a4d1"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-afs-puzzles-homepage-fix-critical-qa-issues"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32868"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGEFrom guardian/actions-ecr. |
github-actions
Bot
removed
the
run_chromatic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes the following "should" priority issues from the Puzzles QA spreadsheet:
https://docs.google.com/spreadsheets/d/1kXDzncSNHru01oIU-kSvQntPcsQEFSkGsvgllrwHkhI/edit?gid=1669673750#gid=1669673750
leftCol. Removed the override, so it uses the same 8px as the other containers.tablet, the gap between standard cards and between card groups is now 24px and the separator sits 8px above the card below. The nested containers (word games, logic puzzles) follow the same rule.tablet, compact card rows now have a 14px row gap and the separator sits 6px above the card below. The column gap and the vertical separators are unchanged.From
tabletupwards nothing changes.Checked, no code change needed here
cardTextStylesalready has a 4px top padding at every breakpoint.PuzzlesArchiveMenualready hasmargin-top: 28pxfromtabletand20pxbelow it.Why?
QA found these differences between the Puzzles hub and the designs.
How has this change been tested?
PuzzlesDirectory,PuzzlesSupporting,PuzzlesLayout,PuzzlesArchiveandMorePuzzlesCardsuites pass. eslint, stylelint and prettier report no errors on the changed files.Screenshots