{{ message }}
Repository navigation
Conversation
Both fields are required, but a missing one caused an NPE from Double.floatValue() with no hint of which field was absent. Check them explicitly, matching the "cannot be empty" messages used for the required retryPolicy and hedgingPolicy fields.
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
ServiceConfigUtil.getThrottlePolicy()reads the two required fields ofretryThrottlingwithJsonUtil.getNumberAsDouble(...).floatValue(). Wheneither field is missing,
getNumberAsDoublereturns null and the call failswith an NPE:
ScParsercatches it and the channel reportsUNKNOWN: failed to parse service config, but the cause doesn't say which field is missing. This wasnoted in the code as
TODO(dapengzhang0): check if this is null.Fix
Check both fields with
checkNotNull(..., "<field> cannot be empty"), thesame message used for the required
retryPolicyandhedgingPolicyfieldsin
ManagedChannelServiceConfig. The exception type is still the NPE thatScParseralready handles, so the only change is a clearer message.Testing
Added
getThrottlePolicy_failOnMissingMaxTokensandgetThrottlePolicy_failOnMissingTokenRatiotoServiceConfigUtilTest. Bothfailed before the fix with the NPE above.