{{ message }}
Repository navigation
core: Handle new PF enabled - #13094
Merged
Merged
Conversation
Only add RawMessageClientInterceptor to the interceptor chain in XdsNameResolver when either GRPC_EXPERIMENTAL_XDS_EXT_PROC_ON_CLIENT or GRPC_EXPERIMENTAL_XDS_EXT_PROC_ON_SERVER is true. This prevents RawMessageClientInterceptor from corrupting method descriptors and causing empty payloads on retry attempts for regular xDS channels. Fixes grpc#13010 TAG=agy CONV=56c87717-243d-4f12-af9e-c532e509892a
…ests Enable GRPC_EXPERIMENTAL_ENABLE_NEW_PICK_FIRST by default in PickFirstLoadBalancerProvider. Duplicate failing tests in GrpclbLoadBalancerTest to verify both legacy PickFirstLoadBalancer and modern PickFirstLeafLoadBalancer behaviors. TAG=agy CONV=2b34d6af-c0df-46b4-8326-2dea3641f8cc
Update requestConnection invocation counts and intermediate state verifications in GrpclbLoadBalancerTest to match PickFirstLeafLoadBalancer's state tracking behavior when connecting from IDLE. TAG=agy CONV=2b34d6af-c0df-46b4-8326-2dea3641f8cc
Separate lb_working_withDefaultTarget_rlsResponding into legacy and new pick-first test variants with the appropriate InOrder createSubchannel verifications. TAG=agy CONV=2b34d6af-c0df-46b4-8326-2dea3641f8cc
…ew pick-first PickFirstLeafLoadBalancer does not trigger a second refreshNameResolution when transitioning from TRANSIENT_FAILURE to IDLE during backoff. Duplicate pickAfterStateChange to verify both old and new PF behaviors. TAG=agy CONV=2b34d6af-c0df-46b4-8326-2dea3641f8cc
…LeastRequest Duplicated failing tests in RingHashLoadBalancerTest and LeastRequestLoadBalancerTest to test legacy PickFirst and new PickFirst behaviors separately under both flag configurations. TAG=agy CONV=2b34d6af-c0df-46b4-8326-2dea3641f8cc
ejona86
reviewed
Oct 8, 2026
Member
There was a problem hiding this comment.
Instead of copying the entire test, and I assume you made some change in there but there's no great way for me to review it, can we not just conditionalize the asserts that needs adjusting? Like:
grpc-java/xds/src/test/java/io/grpc/xds/LeastRequestLoadBalancerTest.java
Lines 641 to 643 in 5ecce90
Member
There was a problem hiding this comment.
I had mentioned that we'll want to do this in a separate commit, so any revert would be small and wouldn't require re-changing the tests to roll-forward.
Contributor
Author
There was a problem hiding this comment.
Reverted back to false.
Refactor test suites across grpclb, rls, util, and xds to remove duplicated _newPickFirst test variants in favor of in-place conditional assertions using PickFirstLoadBalancerProvider.isEnabledNewPickFirst(). TAG=agy CONV=2b34d6af-c0df-46b4-8326-2dea3641f8cc
ejona86
approved these changes
Oct 9, 2026
ejona86
left a comment
ejona86
left a comment
Member
There was a problem hiding this comment.
Make sure to adjust the commit title when merging, because this PR is no longer enabling new pick first by default.
kannanjgithub
changed the title
kannanjgithub
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make tests detect and handle when new PickFirst LB is enabled.