{{ message }}
binder: Let the server know when the client fails to authorize it.#12445
Merged
Conversation
Avoids handshake timeout on the server side in this case. Also has the nice side effect that the client handshake code doesn't have to pass the server's binder from async function to function as an argument.
ejona86
approved these changes
Oct 27, 2025
ejona86
left a comment
ejona86
left a comment
Member
There was a problem hiding this comment.
I expect the code was delaying setOutgoingBinder() on purpose, to prevent accidentally sending on a unauthenticated binder. But that can be changed. It seems to have simply been a bug where the client wouldn't notify the server of failures during handshaking. I agree the code should notify the server when shut down while handshaking.
Note that the text of #12438 would seem to imply "Wire format version mismatch" and "Malformed SETUP_TRANSPORT data" aren't handled properly, and you didn't actually change the behavior here. But they don't respond because the handshake was too broken to figure out how to respond.
Member
Author
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Nov 3, 2025
…rpc#12445) Avoids waiting for the handshake timeout on the server side in this case. I also add test coverage for the `!setOutgoingBinder()` case to make sure it works in the new location. My ulterior motive for this change is simplifying the client handshake code in preparation for grpc#12398 -- An (impossible) !isShutdown() clause goes away for easy to understand reasons and I'll no longer have to pass the server's binder as an arg from async function to function in two separate handshake impls. Fixes grpc#12438
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids waiting for the handshake timeout on the server side in this case.
I also add test coverage for the
!setOutgoingBinder()case to make sure it works in the new location.My ulterior motive for this change is simplifying the client handshake code in preparation for #12398 -- An (impossible) !isShutdown() clause goes away for easy to understand reasons and I'll no longer have to pass the server's binder as an arg from async function to function in two separate handshake impls.
TGP passes: fusion2/OCL:823722865:BASE:823829545:1761379767122:2d595b69
Fixes #12438