{{ message }}
xds: Plumb system root certs similarly to CertProviders#12374
Closed
ejona86 wants to merge 1 commit into
Closed
Conversation
Contributor
Contributor
|
I have incorporated these changes into my PR #12340 with the fixes. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Considering as an alternative to #12340.
XdsSecurityClientServerTest is failing because the exception changed; I don't know why it is failing during a different part of handshaking now. The other test failures are white box tests that have to get updated, because of
IgnoreUpdatesWatcher. If we like this, I don't know if you want to take it and fix the tests (and add tests), or wait for me.