Fix typos: `hanlde` -> `handle`, `prefernce` -> `preference` by junhoyeo · Pull Request #193 · gridaco/code · GitHub
Skip to content

Fix typos: hanlde -> handle, prefernce -> preference #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
softmarshmallow merged 2 commits into from
Nov 29, 2022
Merged

Fix typos: hanlde -> handle, prefernce -> preference #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e52971d
fix typo: `hanlde` -> `handle`
junhoyeo Nov 29, 2022
60a67d0
fix typo: `prefernce` -> `preference`
junhoyeo Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/figma-autolayout.md
View file
Open in desktop
2 changes: 1 addition & 1 deletion editor/pages/figma/inspect-component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default function InspectComponent() {
<div style={{ margin: 60 }}>
<h2>Not a component</h2>
<p>
This page cannot hanlde other types than <code>COMPONENT</code> or
This page cannot handle other types than <code>COMPONENT</code> or
<code>INSTANCE</code>
</p>
<p>
Expand Down
6 changes: 3 additions & 3 deletions packages/builder-web-react/react-styled-component-widget/from-reusable-widget-tree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ export function finalizeReactReusable_StyledComponents__Experimental({
tree: InstanceWidget;
components: MasterComponentWidget[];
}) {
const hanlde = (token) => {
const handle = (token) => {
if (token instanceof InstanceMetaToken) {
const children = token.master["children"]?.map(hanlde);
const children = token.master["children"]?.map(handle);
return {
...token.master,
children,
Expand All @@ -31,7 +31,7 @@ export function finalizeReactReusable_StyledComponents__Experimental({
}
};

const token = hanlde(tree);
const token = handle(tree);
const webwi = compose(token, {});
const builder = new ReactStyledComponentsModuleBuilder({
entry: webwi,
Expand Down
4 changes: 2 additions & 2 deletions packages/designto-token/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ For example,
In this scenario, regardingless how much single pltform's design is exceptional, the data should follow the hierarchical shape to satisfy all platfrom.

**The reason is..**
all the processing logic should be handled on tokenizer and the tokens are the result of the decision tree. No heavy, decision changing logic should be hanlded after the tokenization.
all the processing logic should be handled on tokenizer and the tokens are the result of the decision tree. No heavy, decision changing logic should be handled after the tokenization.

e.g. All design elements has its position, but not all nodes are being placed statically on that posision. by wrapping (not as property) the position, we can tell the later hanlders that this is already decided to be positioned and have its static posision specified. - if we don't do this way each logic by frameworks will be fragmented and unable to maintain.
e.g. All design elements has its position, but not all nodes are being placed statically on that posision. by wrapping (not as property) the position, we can tell the later handlers that this is already decided to be positioned and have its static posision specified. - if we don't do this way each logic by frameworks will be fragmented and unable to maintain.

### The first approach (noisy and accurate one)

Expand Down
50 changes: 25 additions & 25 deletions packages/support-flags/parse.ts
View file
Open in desktop