{{ message }}
Repository navigation
#434 Add GraphQlInputObjectType reference for NonNull INput types at … - #435
Merged
Conversation
…onNull INput types at Runtime Wiring - Added to the determineType the same approeach as determineInputType, but without the creation of non existing INput types (this could lead to infinity recursion) - Added Groovy Unit Test to ensure the problem is solved
Author
oryan-block
requested changes
Dec 15, 2020
oryan-block
left a comment
oryan-block
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me. Just a couple minor suggestions.
oryan-block
previously approved these changes
Dec 16, 2020
…ing_on_nonnull_input
…ing_on_nonnull_input # Conflicts: # src/test/groovy/graphql/kickstart/tools/SchemaParserSpec.groovy
oryan-block
previously approved these changes
Mar 5, 2021
…ing_on_nonnull_input # Conflicts: # src/test/kotlin/graphql/kickstart/tools/SchemaParserTest.kt
oryan-block
approved these changes
Mar 5, 2021
vojtapol
approved these changes
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #434 Add GraphQlInputObjectType reference for NonNull INput types at …Runtime Wiring
Checklist
Description