Circular input property leads to stackoverflow · Issue #409 · graphql-java-kickstart/graphql-java-tools · GitHub
Skip to content

Circular input property leads to stackoverflow #409

Closed
#414
Closed
Circular input property leads to stackoverflow#409
#414
Labels
bug

Description

@KammererTob
KammererTob
opened on Jun 22, 2020

After updating graphql-java-tools to 6.1.0 i have encountered a stackoverflow exception on startup. I think that the problem was introduced in this commit: 10ee43f and happens because of the interaction between determineInputType and createInputObject.
Example schema:

input A {
    id: ID!
    b: B
}

input B {
   id: ID!
   a: A
}

According to the spec this should be allowed (graphql/graphql-spec#445, graphql/graphql-spec#189), which leads me to believe that this is a bug.

Activity

  1. KammererTob
    changed the title [-]Circular input property leads to Stackoverflow[/-] [+]Circular input property leads to stackoverflow[/+] on Jun 22, 2020
  2. vojtapol
    added
    bug
    on Jun 22, 2020

  3. vojtapol commented on Jul 2, 2020

    @vojtapol
    vojtapol
    on Jul 2, 2020
    Member

    Confirmed bug. Contributions welcome.

  4. KammererTob
    added a commit that references this issue on Jul 4, 2020

    Fix for graphql-java-kickstart#409

    a6393e0

  5. enriquedacostacambio commented on Sep 29, 2020

    @enriquedacostacambio
    enriquedacostacambio
    on Sep 29, 2020

    fyi, simple (non-mutual) recursion also triggers the bug:

    input CriterionInput {
    and: [CriterionInput!]
    or: [CriterionInput!]
    not: CriterionInput
    status: StatusCriterionInput
}

input StatusCriterionInput {
    eq: String
}

  6. PhilippS93 commented on Oct 22, 2020

    @PhilippS93
    PhilippS93
    on Oct 22, 2020

    Can confirm. This is especially important for filtering purposes like recursive OR and AND patterns.

  7. vojtapol
    closed this as completedin #414on Dec 14, 2020
  8. vojtapol
    added a commit that references this issue on Dec 14, 2020

    Merge pull request #414 from KammererTob/master

    3abb3ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions