`graphql-java` version 22 compatibility by hiddewie · Pull Request #573 · graphql-java-kickstart/graphql-java-servlet · GitHub
Skip to content

graphql-java version 22 compatibility#573

Merged
federicorispo merged 7 commits into
graphql-java-kickstart:masterfrom
hiddewie:version-22
Jul 28, 2024
Merged

graphql-java version 22 compatibility#573
federicorispo merged 7 commits into
graphql-java-kickstart:masterfrom
hiddewie:version-22

Conversation

@hiddewie

@hiddewie hiddewie commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

This PR makes the project compatible with GraphQL Java version 22

Changes:

  • Depend on com.graphql-java:graphql-java version 22
  • Remove everything DataLoaderDispatcherInstrumentation related
  • Add valid locations in a test setup.

Ref graphql-java/graphql-java#3447, which has most impact on this pull request.

@hiddewie hiddewie changed the title Version 22 graphql-java version 22 compatibility Jul 26, 2024
@hiddewie hiddewie marked this pull request as ready for review July 26, 2024 14:03
@federicorispo federicorispo self-requested a review July 26, 2024 21:19
@federicorispo federicorispo added the dependencies Pull requests that update a dependency file label Jul 26, 2024
@federicorispo

Copy link
Copy Markdown
Member

@hiddewie

Copy link
Copy Markdown
Contributor Author

@federicorispo Thanks for the review!

I removed the dead code :)

@federicorispo federicorispo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this delicate verison bump 🚀

@federicorispo federicorispo merged commit 866fa5c into graphql-java-kickstart:master Jul 28, 2024
@hiddewie

Copy link
Copy Markdown
Contributor Author

@federicorispo Is it possible to make a new (major?) version with these changes?

@federicorispo

federicorispo commented Jul 30, 2024

Copy link
Copy Markdown
Member

Yes of course, but first I would like to test the other minor dependency bumps before merge them and release a new major (in a day or two).

If you want, you can test the snapshot version 15.2.1-SNAPSHOT created on the master branch and available here

    <repository>
      <id>oss.sonatype.org-snapshot</id>
      <url>https://oss.sonatype.org/content/repositories/snapshots</url>
      <releases>
        <enabled>false</enabled>
      </releases>
      <snapshots>
        <enabled>true</enabled>
      </snapshots>
    </repository>

@hiddewie

Copy link
Copy Markdown
Contributor Author

Perfect, thank you!

@hiddewie

Copy link
Copy Markdown
Contributor Author

Hi @federicorispo, did you manage to release a new version so I can update all my projects using normal versions instead of snapshot versions? I don't see it listed in https://github.com/graphql-java-kickstart/graphql-java-servlet/releases. Thanks!

@federicorispo

Copy link
Copy Markdown
Member

@hiddewie Hi, I released the version 16.0.0 of the graphql-java-servlet with the graphql-java version 22.3

@hiddewie

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants