{{ message }}
Conversation
…tegy The coverage gate was flaking on dispatchImpl's CAS retry branches because they only execute under real thread contention, making coverage non-deterministic. This adds targeted tests that inject simulated CAS failures to deterministically exercise both retry paths (dispatch-setup and early-exit) without relying on thread scheduling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExhaustedDataLoaderDispatchStrategy.dispatchImplbecause its CAS retry branches only execute under real thread contention, making coverage non-deterministic (see PR Change Dependabot update schedule from weekly to monthly #4326 for an example)ContendedCallStacktest subclass that selectively injects CAS failures targeting specific state transitions, deterministically exercising both retry paths without relying on thread schedulingCallStackinner class package-private and adds a@VisibleForTestingconstructor to support test injection — no behavioral changes to production codeTest plan
ExhaustedDataLoaderDispatchStrategyTesttests passdispatchImplandExhaustedDataLoaderDispatchStrategyoverall🤖 Generated with Claude Code