{{ message }}
Fix jar file naming when branch contains slashes#4290
Merged
Conversation
Branch names like `feature/my-change` produce a version string with `/` characters (e.g. `0.0.0-feature/my-change-SNAPSHOT`), which breaks the jar file path. Replace `/` and `\` in the branch name with `-` so the resulting jar file name is always valid. https://claude.ai/code/session_016vUi9axZU9DGXryxPWiwwT
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/(e.g.feature/my-change) are used directly in the development version string, producing jar file names likegraphql-java-0.0.0-feature/my-change-SNAPSHOT.jar/in the file name breaks file paths and build tooling/and\characters in the branch name with-before constructing the version stringTest plan
/in the name (e.g.feature/test) and run./gradlew jar— the jar file should have-instead of/in its namehttps://claude.ai/code/session_016vUi9axZU9DGXryxPWiwwT