Revert "New spec validation: Subscriptions root field must not contain @skip nor @include on root selection set" by dondonz · Pull Request #3917 · graphql-java/graphql-java · GitHub
Skip to content

Revert "New spec validation: Subscriptions root field must not contain @skip nor @include on root selection set"#3917

Merged
dondonz merged 1 commit intomasterfrom
revert-3871-subscriptions-root-field
Apr 15, 2025
Merged

Revert "New spec validation: Subscriptions root field must not contain @skip nor @include on root selection set"#3917
dondonz merged 1 commit intomasterfrom
revert-3871-subscriptions-root-field

Conversation

@dondonz
Copy link
Copy Markdown
Member

@dondonz dondonz commented Apr 15, 2025

Reverts #3871

There is an error with coercing variables at this point, this needs to be fixed to either only coerce variables relating to directives or pull in all variables from execution input. Proper fix coming later but let's revert for now

@github-actions
Copy link
Copy Markdown
Contributor

@dondonz dondonz merged commit 14d7411 into master Apr 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant