[WIP] Add simple cycles algorithm by phyrwork · Pull Request #33 · graphp/algorithms · GitHub
Skip to content

[WIP] Add simple cycles algorithm - #33

Closed
phyrwork wants to merge 2 commits into
graphp:masterfrom
phyrwork:simple-cycles
Closed

phyrwork wants to merge 2 commits into
graphp:masterfrom
phyrwork:simple-cycles

Conversation

@phyrwork

@phyrwork phyrwork commented Oct 7, 2018

Copy link
Copy Markdown
Contributor

Depends on #26

Test cases for

  • Simple cycle
  • Isolated strongly connected components
  • Connected strongly connected components

@phyrwork

Copy link
Copy Markdown
Contributor Author

@clue clue changed the title Add simple cycles algorithm [WIP] Add simple cycles algorithm Oct 11, 2018
@jp928

jp928 commented Nov 14, 2019

Copy link
Copy Markdown

@phyrwork
Do you mind to share what is the bug you mentioned?
I wish I could help.

@clue

clue commented Feb 19, 2020

Copy link
Copy Markdown
Member

@phyrwork Thank you for filing this PR and for your patience! 👍 This PR is currently marked as WIP, are you planning to update this again?

I'd first like to get a maintenance release out to bring this library up to date before introducing any additional algorithms. Once this is done, I'm looking forward to merging more of these algorithms, so I hope you're still interested in getting this merged then :shipit:

Again thank you for your valuable contribution! I understand this long wait time can be frustrating, so rest assured I'll try to get these intermediary release out as soon as time permits (this project doesn't currently get any sponsoring, so this happens mostly in my spare free time) and will then look into this PR again in more depth! 👍

@clue
clue deleted the branch graphp:master October 30, 2022 13:49
@clue clue closed this Oct 30, 2022
@SimonFrings

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants