ci: add codespell spell check and extend python linting to dev scripts by james-willis · Pull Request #864 · graphframes/graphframes · GitHub
Skip to content

ci: add codespell spell check and extend python linting to dev scripts#864

Merged
james-willis merged 3 commits into
graphframes:mainfrom
james-willis:ci/spellcheck-and-dev-linting
Jun 16, 2026
Merged

ci: add codespell spell check and extend python linting to dev scripts#864
james-willis merged 3 commits into
graphframes:mainfrom
james-willis:ci/spellcheck-and-dev-linting

Conversation

@james-willis

@james-willis james-willis commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

Some CI improvements. spell check + more linter coverage for CI scripts

Why are the changes needed?

Keeps our docs and source code typo free + well formated. improves maintainability and professionalism. Reduces review churn

@james-willis james-willis marked this pull request as ready for review June 16, 2026 18:09
- Add codespell (config in .codespellrc) covering yml, python and scala
  via a new Spell Check workflow and a pre-commit hook; fix the typos it
  surfaced across sources and docs. graphx/ is excluded to stay aligned
  with upstream Apache Spark.
- Extend black/flake8/isort to the dev/ and python/dev/ scripts in both
  the Python CI code-style step and pre-commit.
…iscovery

When ../dev is included, black/isort resolve their config from the common
parent of all paths (the repo root, which has no pyproject.toml) and fall
back to defaults. Pass --config/--settings-path explicitly.
@james-willis james-willis force-pushed the ci/spellcheck-and-dev-linting branch from 4323a68 to 78f5066 Compare June 16, 2026 21:37
run_connect.py and stop_connect.py were added in graphframes#863 before the linting scope was extended to dev/. Apply black/isort and add a noqa for an unavoidable long config string so python-ci passes.
@codecov-commenter

Copy link
Copy Markdown

@james-willis james-willis merged commit 28d181c into graphframes:main Jun 16, 2026
11 checks passed
@james-willis james-willis deleted the ci/spellcheck-and-dev-linting branch June 16, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants